Bug 2223224
| Summary: | Review Request: fractal - Matrix group messaging app | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pete Walter <walter.pete> |
| Component: | Package Review | Assignee: | Chris Sandler <chr77> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | chr77, decathorpe, mjg, package-review |
| Target Milestone: | --- | Flags: | chr77:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-08-15 02:27:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Pete Walter
2023-07-16 20:59:32 UTC
Thank you for finally getting fractal into Fedora! I was surprised to find out that nobody had done the packaging work until now. Rpmlint: Ok Licensing: Ok Spec file: Ok Follows packaging guidelines: Ok Compiles in koji: Ok Installs and runs without errors: Ok Review guidelines checklist: Ok Everything looks good to me. I have set fedora-review+ flag. Please let me know if I missed some step as I am not an experienced reviewer. The Pagure repository was created at https://src.fedoraproject.org/rpms/fractal Oy, hold your horses. The source tarball contains a vendored copy of all the Rust dependencies. That alone is a violation of the Packaging Guidelines and the Rust Packaging Guidelines. And even if you want to ignore this, you would *at least* need to declare *which* dependencies are vendored, and what their licenses are. Fabio: You are wrong. Packaging Guidelines allow bundled dependencies if we cannot use system libraries. In this case a lot of bundled rust libraries are missing so we cannot use the system libraries. Feel free to add them to fedora and let me know. For the record, I wanted to avoid bundled libraries at first but after you flat out refused to let me take keep the rust dependencies that fractal needs from retirement (please kindly refer to https://pagure.io/releng/issue/11372) I have given up on that. If you want fractal to use packaged dependencies, feel free to go ahead and add them to fedora and I will switch over to them but I am done with interacting with someone who just flat out refuses to cooperate. I will work on adding bundled() provides next weekend. Thank you for pointing that out. Chris: Thanks a lot for the review! Do you want to be a comaintainer? (In reply to Pete Walter from comment #4) > Fabio: You are wrong. Packaging Guidelines allow bundled dependencies if we > cannot use system libraries. In this case a lot of bundled rust libraries > are missing so we cannot use the system libraries. Feel free to add them to > fedora and let me know. I checked the bundled dependencies, and like 95% of them are already available in Fedora. The biggest missing piece is the Matrix SDK, which is included as a git snapshot. Since we cannot package those separately, bundling those is OK. As far as I can tell, that only leaves a handful of missing crates. > For the record, I wanted to avoid bundled libraries at first but after you > flat out refused to let me take keep the rust dependencies that fractal > needs from retirement (please kindly refer to > https://pagure.io/releng/issue/11372) I have given up on that. I'm sorry how that turned out. It seems that there was a misunderstanding. If you read that ticket, I actually offered help with packaging whatever you were working on, I just objected to the fact that you wanted to become new main maintainer of a few packages that I was still maintaining in stable branches, but which were retired in rawhide. > If you want > fractal to use packaged dependencies, feel free to go ahead and add them to > fedora and I will switch over to them but I am done with interacting with > someone who just flat out refuses to cooperate. I offered help the second I saw that you wanted to unretire Rust packages. I'm not sure how that qualifies as "refusing to cooperate" ... > I will work on adding bundled() provides next weekend. Thank you for > pointing that out. You can use the %cargo_license and %cargo_license_summary macros as well. They simplify the task of creating an accurate License tag (which is missing from the package right now). That's the more important reason I'd have not approved this package as-is - bundling your dependencies is OK in some circumstances, but inaccurate license tag never is. > I will work on adding bundled() provides next weekend. Thank you for pointing that out.
Has there been any progress with that?
Also, the package is already in Fedora, so this bug could be closed, IMO.
> You can use the %cargo_license and %cargo_license_summary macros as well. > They simplify the task of creating an accurate License tag (which is missing from the package right now). > That's the more important reason I'd have not approved this package as-is - bundling your dependencies is OK in some circumstances, but inaccurate license tag never is. Those are helpful, thank you. I just updated the license tag in https://src.fedoraproject.org/rpms/fractal/c/7cceb88ec9b114e9deac1ba58b271fdee555ec6d?branch=rawhide FEDORA-2023-011ecbf64b has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-011ecbf64b FEDORA-2023-011ecbf64b has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-848bd7f4c1 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-848bd7f4c1 FEDORA-2023-848bd7f4c1 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |