Bug 2223420

Summary: ssh-x-forwarding.csh incorrectly starts new DBUS session when using X2Go
Product: Red Hat Enterprise Linux 8 Reporter: Orion Poplawski <orion>
Component: dbusAssignee: David King <dking>
Status: NEW --- QA Contact: Petr Schindler <pschindl>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 8.8CC: desktop-qa-list, rstrode, tpopela
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Orion Poplawski 2023-07-17 18:33:10 UTC
Description of problem:

ssh-x-forwarding.sh has a check to see if $DISPLAY is local:

[ "${DISPLAY:0:1}" = ":" ] && return

but ssh-x-forwarding.csh does not have the equivalent check.  This causes a new temporary dbus session to get started when a user with a tcsh login shell starts an X2Go session.  I've filed a PR here with a fix:

https://git.centos.org/rpms/dbus/pull-request/1

Version-Release number of selected component (if applicable):
dbus-x11-1.12.8-24.el8.x86_64

How reproducible:
Every time

Steps to Reproduce:
1. User with tcsh/csh connects via X2Go
2. Suspend and resume session
3. dbus required items (launching KDE system settings) fail

Comment 1 Tomas Popela 2023-07-21 07:00:02 UTC
(In reply to Orion Poplawski from comment #0)
> I've filed a PR here with a fix:
> 
> https://git.centos.org/rpms/dbus/pull-request/1

I don't think that git.centos.org is used (definitely not by us) - I think that you should rather do the merge request against https://gitlab.com/redhat/centos-stream/rpms/dbus/-/tree/c8s?ref_type=heads.

Comment 2 Orion Poplawski 2023-07-22 02:03:32 UTC
Sorry, I'm stuck in the past it seems.  New one filed:

https://gitlab.com/redhat/centos-stream/rpms/dbus/-/merge_requests/8

Comment 3 Orion Poplawski 2023-07-22 02:11:21 UTC
That was against the wrong branch.  c8s one - https://gitlab.com/redhat/centos-stream/rpms/dbus/-/merge_requests/9