Bug 2223420

Summary: ssh-x-forwarding.csh incorrectly starts new DBUS session when using X2Go
Product: Red Hat Enterprise Linux 8 Reporter: Orion Poplawski <orion>
Component: dbusAssignee: David King <dking>
Status: CLOSED MIGRATED QA Contact: Petr Schindler <pschindl>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 8.8CC: desktop-qa-list, rstrode, tpopela
Target Milestone: rcKeywords: MigratedToJIRA
Target Release: ---Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-09-15 17:44:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Orion Poplawski 2023-07-17 18:33:10 UTC
Description of problem:

ssh-x-forwarding.sh has a check to see if $DISPLAY is local:

[ "${DISPLAY:0:1}" = ":" ] && return

but ssh-x-forwarding.csh does not have the equivalent check.  This causes a new temporary dbus session to get started when a user with a tcsh login shell starts an X2Go session.  I've filed a PR here with a fix:

https://git.centos.org/rpms/dbus/pull-request/1

Version-Release number of selected component (if applicable):
dbus-x11-1.12.8-24.el8.x86_64

How reproducible:
Every time

Steps to Reproduce:
1. User with tcsh/csh connects via X2Go
2. Suspend and resume session
3. dbus required items (launching KDE system settings) fail

Comment 1 Tomas Popela 2023-07-21 07:00:02 UTC
(In reply to Orion Poplawski from comment #0)
> I've filed a PR here with a fix:
> 
> https://git.centos.org/rpms/dbus/pull-request/1

I don't think that git.centos.org is used (definitely not by us) - I think that you should rather do the merge request against https://gitlab.com/redhat/centos-stream/rpms/dbus/-/tree/c8s?ref_type=heads.

Comment 2 Orion Poplawski 2023-07-22 02:03:32 UTC
Sorry, I'm stuck in the past it seems.  New one filed:

https://gitlab.com/redhat/centos-stream/rpms/dbus/-/merge_requests/8

Comment 3 Orion Poplawski 2023-07-22 02:11:21 UTC
That was against the wrong branch.  c8s one - https://gitlab.com/redhat/centos-stream/rpms/dbus/-/merge_requests/9

Comment 4 RHEL Program Management 2023-09-15 17:42:39 UTC
Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug.

Comment 5 RHEL Program Management 2023-09-15 17:44:20 UTC
This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.