Bug 2224051

Summary:	Dampening ignored by attrd_updater -U for initial attribute creation
Product:	Red Hat Enterprise Linux 9	Reporter:	Ken Gaillot <kgaillot>
Component:	pacemaker	Assignee:	Ken Gaillot <kgaillot>
Status:	VERIFIED ---	QA Contact:	cluster-qe <cluster-qe>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	9.2	CC:	cfeist, cluster-maint, msmazova
Target Milestone:	rc	Keywords:	Regression, Triaged, ZStream
Target Release:	9.3
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	pacemaker-2.1.6-6.el9	Doc Type:	Bug Fix
Doc Text:	Cause: Since upstream version 2.1.5, a regression caused attrd_updater to ignore the -d/--delay option when combined with -U/--update. Consequence: A node attribute created with attrd_updater using the -U/-update and -d/--delay options would not have the desired delay. Fix: The -d/--delay option is again considered when used with -U/--update. Result: The desired delay is effective.	Story Points:	---
Clone Of:	2224046
Clones:	2224071 (view as bug list)		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:	2.1.7
Embargoed:
Bug Depends On:	2224046
Bug Blocks:	2224071

Description Ken Gaillot 2023-07-19 16:44:57 UTC

+++ This bug was initially created as a clone of Bug #2224046 +++

Description of problem: When the attrd_updater tool is given the -U/--update option and the -d/--delay option, the behavior before RHEL 8.8 was that the delay would be used if the node attribute needed to be created, and ignored otherwise. Since RHEL 8.8, the delay is always ignored, due to a regression introduced in pacemaker upstream version 2.1.5.


Version-Release number of selected component (if applicable): 2.1.5-*

How reproducible: reliably

Steps to Reproduce:
1. Configure and start a cluster.
2. Create a new node attribute using attrd_updater with -U and -d.
3. Change the node attribute value a little later using any command.

Actual results: Value changes immediately.

Expected results: Value is not changed until after the specified delay.

--- Additional comment from Ken Gaillot on 2023-07-19 16:41:45 UTC ---

Fixed by upstream commit ebac530c

Comment 6 Markéta Smazová 2023-08-08 15:00:11 UTC

after fix:
----------

>    [root@virt-538 ~]# rpm -q pacemaker
>    pacemaker-2.1.6-7.el9.x86_64

>    [root@virt-538 ~]# attrd_updater --name test --update old --delay 40

/var/log/pacemaker/pacemaker.log:
>    Aug 08 16:49:05.797 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-attrd     [506598] (update_attr_on_host) 	notice: Setting test[virt-538] in instance_attributes: (unset) -> old | from virt-538 with 40s write delay
>    Aug 08 16:49:05.798 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-attrd     [506598] (attrd_write_attribute) 	info: Write out of 'test' delayed: timer is running
>    Aug 08 16:49:45.799 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-attrd     [506598] (attrd_write_attribute) 	info: Sent CIB request 8 with 1 change for test (id n/a, set n/a)
>    Aug 08 16:49:45.799 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-attrd     [506598] (lrmd_ipc_connect) 	info: Connecting to executor
>    Aug 08 16:49:45.799 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-based     [506595] (cib_process_request) 	info: Forwarding cib_modify operation for section status to all (origin=local/attrd/8)
>    Aug 08 16:49:45.805 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-based     [506595] (log_info) 	info: Diff: --- 0.9.8 2
>    Aug 08 16:49:45.805 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-based     [506595] (log_info) 	info: Diff: +++ 0.9.9 (null)
>    Aug 08 16:49:45.805 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-based     [506595] (log_info) 	info: +  /cib:  @num_updates=9
>    Aug 08 16:49:45.805 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-based     [506595] (log_info) 	info: ++ /cib/status/node_state[@id='1']/transient_attributes[@id='1']/instance_attributes[@id='status-1']:  <nvpair id="status-1-test" name="test" value="old"/>
>    Aug 08 16:49:45.806 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-based     [506595] (cib_process_request) 	info: Completed cib_modify operation for section status: OK (rc=0, origin=virt-538/attrd/8, version=0.9.9)
>    Aug 08 16:49:45.806 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-attrd     [506598] (attrd_cib_callback) 	info: CIB update 8 result for test: OK | rc=0
>    Aug 08 16:49:45.806 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-attrd     [506598] (attrd_cib_callback) 	info: * test[virt-538]=old
>    Aug 08 16:49:45.807 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-controld  [506600] (abort_transition_graph) 	info: Transition 4 aborted by status-1-test doing create test=old: Transient attribute change | cib=0.9.9 source=abort_unless_down:297 path=/cib/status/node_state[@id='1']/transient_attributes[@id='1']/instance_attributes[@id='status-1'] complete=true

>    [root@virt-538 ~]# date; attrd_updater --name test --update new
>    Tue Aug  8 04:50:11 PM CEST 2023

/var/log/pacemaker/pacemaker.log:
>    Aug 08 16:50:11.604 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-attrd     [506598] (update_attr_on_host) 	notice: Setting test[virt-538] in instance_attributes: old -> new | from virt-538 with 40s write delay
>    Aug 08 16:50:51.606 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-based     [506595] (cib_process_request) 	info: Forwarding cib_modify operation for section status to all (origin=local/attrd/9)
>    Aug 08 16:50:51.606 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-attrd     [506598] (attrd_write_attribute) 	info: Sent CIB request 9 with 1 change for test (id n/a, set n/a)
>    Aug 08 16:50:51.609 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-based     [506595] (log_info) 	info: Diff: --- 0.9.9 2
>    Aug 08 16:50:51.609 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-based     [506595] (log_info) 	info: Diff: +++ 0.9.10 (null)
>    Aug 08 16:50:51.609 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-based     [506595] (log_info) 	info: +  /cib:  @num_updates=10
>    Aug 08 16:50:51.609 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-based     [506595] (log_info) 	info: +  /cib/status/node_state[@id='1']/transient_attributes[@id='1']/instance_attributes[@id='status-1']/nvpair[@id='status-1-test']:  @value=new
>    Aug 08 16:50:51.610 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-based     [506595] (cib_process_request) 	info: Completed cib_modify operation for section status: OK (rc=0, origin=virt-538/attrd/9, version=0.9.10)
>    Aug 08 16:50:51.611 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-controld  [506600] (abort_transition_graph) 	info: Transition 5 aborted by status-1-test doing modify test=new: Transient attribute change | cib=0.9.10 source=abort_unless_down:297 path=/cib/status/node_state[@id='1']/transient_attributes[@id='1']/instance_attributes[@id='status-1']/nvpair[@id='status-1-test'] complete=true
>    Aug 08 16:50:51.611 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-attrd     [506598] (attrd_cib_callback) 	info: CIB update 9 result for test: OK | rc=0
>    Aug 08 16:50:51.611 virt-538.cluster-qe.lab.eng.brq.redhat.com pacemaker-attrd     [506598] (attrd_cib_callback) 	info: * test[virt-538]=new

marking verified in pacemaker-2.1.6-7.el9