Bug 2224193

Summary: Review Request: ipcgull - A GDBus-based IPC library for modern C++
Product: [Fedora] Fedora Reporter: Nicolas De Amicis <deamicis>
Component: Package ReviewAssignee: Vasiliy Glazov <vascom2>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, vascom2
Target Milestone: ---Flags: vascom2: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-07-24 07:01:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
The .spec file difference from Copr build 6189364 to 6189852 none

Description Nicolas De Amicis 2023-07-20 07:06:27 UTC 
Spec URL: https://deamn.fedorapeople.org/ipcgull.spec
SRPM URL: https://deamn.fedorapeople.org/ipcgull-0.1-0.fc39.src.rpm
Description: Ipcgull is a C++ IPC library that takes advantage of modern C++17 features to provide a simple interface for developers to handle IPC.
Currently, Ipcgull only supports a D-Bus backend (via GDBus), but this is abstracted by the library and can theoretically be replaced. However, that is out of scope for this project. This project was originally designed solely for use in LogiOps.
Fedora Account System Username: deamn
Comment 1 Vasiliy Glazov 2023-07-20 07:33:37 UTC 
1. Why debug_package %{nil} ?

2. Release: 0%{?dist}
must be 
Release: 1%{?dist}

3. Need to change License: GPLv3
to
License: GPL-3.0-or-later

4. For devel package need to change Requires:       %{name} = %{version}-%{release}
to
Requires:       %{name}%{?_isa} = %{version}-%{release}

5. All at %prep section can be changed to %autosetup

6. install -D -m 755
must be changed to
install -D -pm 755

7. Remove %ldconfig_scriptlets
Comment 2 Nicolas De Amicis 2023-07-20 09:24:04 UTC 
Please find the spec and srpm files updated like your review:
Spec URL: https://deamn.fedorapeople.org/ipcgull.spec
SRPM URL: https://deamn.fedorapeople.org/ipcgull-0.1-1.fc39.src.rpm
Comment 3 Fedora Review Service 2023-07-20 09:28:27 UTC 
Created attachment 1976690 [details]
The .spec file difference from Copr build 6189364 to 6189852
Comment 4 Vasiliy Glazov 2023-07-20 09:29:49 UTC 
Strange Epoch:   0
and %{cmake} -DPROJECT_EPOCH=%{epoch}

Can you remove this epoch using and set -DPROJECT_EPOCH=0 ?

Seems that for build not need really epoch number from rpm package.
Comment 5 Nicolas De Amicis 2023-07-20 09:39:10 UTC 
(In reply to Vasiliy Glazov from comment #4)
> Strange Epoch:   0
> and %{cmake} -DPROJECT_EPOCH=%{epoch}
> 
> Can you remove this epoch using and set -DPROJECT_EPOCH=0 ?
> 
> Seems that for build not need really epoch number from rpm package.

I replaced by a global project variable. The links still the same but the files are updated accordingly to your suggestion.
Comment 6 Vasiliy Glazov 2023-07-21 05:57:22 UTC 
My fedora-review fall in exception but all seems good now.

Package Approved.

Don't forget to close this ticket after adding package to the repos.
Comment 7 Fedora Admin user for bugzilla script actions 2023-07-24 04:37:52 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/ipcgull