Bug 2224663

Wanted to add - see this issue only when used `annotationFilters` field in the VirtualMachineClone, e.g.:

apiVersion: clone.kubevirt.io/v1alpha1
kind: VirtualMachineClone
metadata:
  name: testclone-cloned
spec:
  source:
    apiGroup: kubevirt.io
    kind: VirtualMachine
    name: vm-fedora-clone
  target:
    apiGroup: kubevirt.io
    kind: VirtualMachine
    name: vm-fedora-clone2
  annotationFilters:
    - "somekey/*"



 Without `annotationFilters` VM succesfully cloned.

Hey @dshchedr 

As can be seen in the user-guide [1] and the code itself [2] the only supported source type as of now are VM and a VM Snapshot.
Am I missing something here?

Also, when I try to do so, I get a nice clean error:
```
> k create -f clone-from-clone.yaml
selecting docker as container runtime
The request is invalid: 
* spec.Source.Kind: Source kind is not supported
```

Closing as not as bug, you're welcome to re-open if I miss anything.

[1] https://kubevirt.io/user-guide/operations/clone_api/
[2] https://github.com/kubevirt/kubevirt/blob/v1.0.0/pkg/virt-controller/watch/clone/clone.go#L113

Maybe you intended to test a clone from a VMSnapshot source?

 @iholder sorry, I guess it's kind of confusing naming: VM clone, VM clone job, cloned VM, etc...

 Let me try explain what I mean: I didn't set VMCLone job as a source, instead - I chose the target VM (from previous cloning), so the full steps:

1) create VM - let's name it _source-vm_
2) clone _source-vm_ to _target-vm_
3) try to clone _target-vm_ (create new vm cloning job which has target VM from previous job as a source)


and if I have this field in cloning job:

>  annotationFilters:
>    - "somekey/*"

I'm getting the error:

> ]: error in remove for path: '/metadata/annotations/kubevirt.io~1latest-observed-api-version': Unable to remove nonexistent key: kubevirt.io/latest-observed-api-version: missing value


 Need to add, I see the problem only for annotationFilters. LabelFilters working good.

Thank you Denys! The bug you found is very real, sorry for the misunderstanding.

The fix is not out: https://github.com/kubevirt/kubevirt/pull/10393.

now*

Tried to verify on CNV-v4.15.0.rhel9-1638 but seems the problem was not fixed (or may be it is some another issue with cloning the clone):

# 1) created VM

> $ oc create -f vm-fedora.yml 
> virtualmachine.kubevirt.io/vm-fedora created

> $ oc get vm
> NAME        AGE    STATUS    READY
> vm-fedora   107s   Running   True

# 2) Succesfully cloned and target VM can be started:

> $ oc get vmclone
> NAME        PHASE       SOURCEVIRTUALMACHINE   TARGETVIRTUALMACHINE
> testclone   Succeeded   vm-fedora              vm-fedora-clone

> $ oc get vm
> NAME              AGE     STATUS    READY
> vm-fedora         2m55s   Running   True
> vm-fedora-clone   59s     Running   True

# 3) Trying to clone second time by using previous target VM as a source:

cloning job stuck in `RestoreInProgress` state
> $ oc get vmclone
> NAME               PHASE               SOURCEVIRTUALMACHINE   TARGETVIRTUALMACHINE
> testclone-cloned   RestoreInProgress   vm-fedora-clone        vm-fedora-clone2

vmrestore contains error message in events:
> $ oc describe vmrestore
>  Warning  VirtualMachineRestoreError  50s                restore-controller  VirtualMachineRestore encountered error virtualmachines.kubevirt.io "vm-fedora-clone2" already exists
>  Warning  VirtualMachineRestoreError  8s (x12 over 49s)  restore-controller  VirtualMachineRestore encountered error admission webhook "mutatevirtualmachines.kubemacpool.io" denied the request: Failed to update virtual machine allocation error: failed to allocate requested mac address

But I see that new VM `vm-fedora-clone2` created:
> $ oc get vm
> NAME               AGE     STATUS    READY
> vm-fedora          3m47s   Running   True
> vm-fedora-clone    111s    Running   True
> vm-fedora-clone2   17s     Stopped   False

 However, when I'm trying to run it - I see the error message:
> $ virtctl start vm-fedora-clone2
> Error starting VirtualMachine Internal error occurred: admission webhook "virtualmachine-validator.kubevirt.io" denied the request: Cannot start VM until restore "clone-testclone-cloned-restore-vm-fedora-clone-r2xqc" completes

just wanted to add - all VMs have different mac addresses:

$ for i in $(oc get vm -o name);do echo $i; oc describe $i | grep "Mac "; done
virtualmachine.kubevirt.io/vm-fedora
            Mac Address:  02:8a:48:00:00:00

virtualmachine.kubevirt.io/vm-fedora-clone
            Mac Address:  02:8a:48:00:00:01

virtualmachine.kubevirt.io/vm-fedora-clone2
            Mac Address:  02:8a:48:00:00:08