Bug 2224692 (golang-github-ravenox-jsonmerge)
| Summary: | Review Request: golang-github-ravenox-jsonmerge - Merge JSON objects to one (replaces only existent values) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert-André Mauchin 🐧 <eclipseo> |
| Component: | Package Review | Assignee: | Pavel Solovev <daron439> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | daron439, package-review |
| Target Milestone: | --- | Flags: | daron439:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | golang-github-ravenox-jsonmerge-1.0.0-1.fc39 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-08-27 00:43:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2224631, 2224634, 2224639, 2224643 | ||
| Bug Blocks: | 2224713 | ||
| Attachments: | |||
|
Description
Robert-André Mauchin 🐧
2023-07-22 05:22:57 UTC
New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-ravenox-jsonmerge.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-ravenox-jsonmerge-1.0.0-1.20230722gitfbb4398.fc38.src.rpm Created attachment 1977045 [details]
The .spec file difference from Copr build 6202986 to 6203326
New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-ravenox-jsonmerge.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-ravenox-jsonmerge-1.0.0-1.20230722git0828c73.fc38.src.rpm Created attachment 1977046 [details]
The .spec file difference from Copr build 6203326 to 6203370
New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-ravenox-jsonmerge.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-ravenox-jsonmerge-1.0.0-1.20230722git0828c73.fc38.src.rpm Created attachment 1977047 [details]
The .spec file difference from Copr build 6203370 to 6203378
The jsonmerge binary will conflict with https://bugzilla.redhat.com/show_bug.cgi?id=2224713. Is it needed here? New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-ravenox-jsonmerge.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-ravenox-jsonmerge-1.0.0-1.20230722git0828c73.fc38.src.rpm Indeed, thanks. Golang Package Review
==============
This package was generated using go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The specfile is sane.
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
Thanks!
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-ravenox-jsonmerge FEDORA-2023-545914b622 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-545914b622 FEDORA-2023-bc71966994 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-bc71966994 FEDORA-2023-bc71966994 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-bc71966994 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-bc71966994 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-545914b622 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-545914b622 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-545914b622 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-545914b622 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-bc71966994 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. |