Bug 2224828

Summary:	[HPP] Metric names fail in metrics name linter
Product:	Container Native Virtualization (CNV)	Reporter:	Assaf Admi <aadmi>
Component:	Metrics	Assignee:	Assaf Admi <aadmi>
Status:	ON_QA ---	QA Contact:	Ahmad <ahafe>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.13.0	CC:	kmajcher, stirabos
Target Milestone:	---
Target Release:	4.14.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Assaf Admi 2023-07-23 10:30:33 UTC

Description of problem:
We applied a metrics names linter in kubevirt/hostpath-provisioner-operator based on promlint. kubevirt_hpp_operator_up_total has failed.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. run `make lint-metrics` in kubevirt/hostpath-provisioner-operator.

Actual results:
kubevirt_hpp_operator_up_total is not aligned with the naming conventions. 

Expected results:
All metrics to aligned with the naming conventions.

Comment 1 Assaf Admi 2023-08-03 10:07:41 UTC

Addressed in https://github.com/kubevirt/hostpath-provisioner-operator/pull/345 and https://github.com/kubevirt/hostpath-provisioner/pull/234.