Bug 2224961

Summary: Review Request: rust-input - Libinput bindings for rust
Product: [Fedora] Fedora Reporter: Davide Cavalca <davide>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/input
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-07-29 23:33:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2224958, 2224960    
Bug Blocks: 2224807    
Attachments:
Description Flags
The .spec file difference from Copr build 6208030 to 6215306 none

Description Davide Cavalca 2023-07-24 04:55:15 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-input/rust-input.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-input/rust-input-0.8.3-1.fc39.src.rpm

Description:
Libinput bindings for rust.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-07-24 16:09:38 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-input/rust-input.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-input/rust-input-0.8.3-1.fc39.src.rpm

Changelog:
- update for input-sys packaging changes

Comment 2 Fedora Review Service 2023-07-24 16:13:50 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6208030
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2224961-rust-input/fedora-rawhide-x86_64/06208030-rust-input/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Davide Cavalca 2023-07-26 23:46:18 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-input/rust-input.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-input/rust-input-0.8.3-1.fc39.src.rpm

Changelog:
- update for input-sys packaging changes

Comment 4 Davide Cavalca 2023-07-26 23:46:35 UTC
This is the rust2rpm.conf I used:

[DEFAULT]
unwanted-features =
  libinput_1_11
  libinput_1_14
  libinput_1_15
  libinput_1_19
  libinput_1_21

Comment 5 Fedora Review Service 2023-07-26 23:49:58 UTC
Created attachment 1980200 [details]
The .spec file difference from Copr build 6208030 to 6215306

Comment 6 Fedora Review Service 2023-07-26 23:50:01 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6215306
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2224961-rust-input/fedora-rawhide-x86_64/06215306-rust-input/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Fabio Valentini 2023-07-29 19:23:49 UTC
Looks good to me, thanks!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Note that just adding "gen" to the default features (both here and in the input-sys crate) will work in most cases, but will *not* work for packages that use "default-features = false". The only robust way to *always* and *reliably* force something like this would be to patch the build.rs file and to remove the conditional compilation for the "gen" feature. It's fine to keep the packages as they are, just beware of this situation. And maybe you remember my comment here when you see very weird build failures some day :)

Comment 8 Fedora Admin user for bugzilla script actions 2023-07-29 23:18:43 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-input

Comment 9 Fedora Update System 2023-07-29 23:32:13 UTC
FEDORA-2023-3c5f01479b has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3c5f01479b

Comment 10 Fedora Update System 2023-07-29 23:33:03 UTC
FEDORA-2023-3c5f01479b has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2023-08-06 21:01:13 UTC
FEDORA-2023-c2d333f341 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c2d333f341

Comment 12 Fedora Update System 2023-08-07 01:26:52 UTC
FEDORA-2023-c2d333f341 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.