Bug 2225405
| Summary: | Review Request: perl-Test-Synopsis-Expectation - Test that SYNOPSIS code produces expected results | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jitka Plesnikova <jplesnik> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Test-Synopsis-Expectation-0.12-1.fc39 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-07-25 11:04:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2224540 | ||
|
Description
Jitka Plesnikova
2023-07-25 09:11:07 UTC
URL and Sourec0 are usable. Ok. TODO: Remove a trailing slash from the URL tag value. A canonical address on CPAN is without the slash. Source0 archive (SHA-512: ed6db5ff2d29d2e49e8d1755da5163bca27fad6b4482c4cf2497086169ec89c0069c200dc818b7b53be9afa79209fface1dab2f71a8953119a8cf5e240a87997) is original. Ok. Summary verified from lib/Test/Synopsis/Expectation.pm. Ok. Description verified from lib/Test/Synopsis/Expectation.pm. Ok. License verified from Build.PL, lib/Test/Synopsis/Expectation.pm, README.md, LICENSE. Ok. No XS code, noarch BuildArch is Ok. TODO: There is a duplicate "Tests" comment in the spec file. TODO: META.json lists <https://github.com/moznion/Test-Synopsis-Expectation> as a home page. Maybe a URL tag should point there. TODO: Unset RELEASE_TESTING environment variable in %build section. Otherwise, xt tests could be performed (Build.PL:32). All tests pass. Ok. $ rpmlint perl-Test-Synopsis-Expectation.spec ../SRPMS/perl-Test-Synopsis-Expectation-0.12-1.fc39.src.rpm ../RPMS/noarch/perl-Test-Synopsis-Expectation-* ======================================== rpmlint session starts ======================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 perl-Test-Synopsis-Expectation-tests.noarch: W: no-documentation ========= 3 packages and 1 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s ======== rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Test-Synopsis-Expectation-0.12-1.fc39.noarch.rpm drwxr-xr-x 2 root root 0 Jul 25 02:00 /usr/share/doc/perl-Test-Synopsis-Expectation -rw-r--r-- 1 root root 873 Dec 16 2014 /usr/share/doc/perl-Test-Synopsis-Expectation/Changes -rw-r--r-- 1 root root 5727 Dec 16 2014 /usr/share/doc/perl-Test-Synopsis-Expectation/README.md drwxr-xr-x 2 root root 0 Jul 25 02:00 /usr/share/licenses/perl-Test-Synopsis-Expectation -rw-r--r-- 1 root root 18391 Dec 16 2014 /usr/share/licenses/perl-Test-Synopsis-Expectation/LICENSE -rw-r--r-- 1 root root 2702 Jul 25 02:00 /usr/share/man/man3/Test::Synopsis::Expectation.3pm.gz drwxr-xr-x 2 root root 0 Jul 25 02:00 /usr/share/perl5/vendor_perl/Test drwxr-xr-x 2 root root 0 Jul 25 02:00 /usr/share/perl5/vendor_perl/Test/Synopsis drwxr-xr-x 2 root root 0 Jul 25 02:00 /usr/share/perl5/vendor_perl/Test/Synopsis/Expectation -rw-r--r-- 1 root root 9837 Jul 25 02:00 /usr/share/perl5/vendor_perl/Test/Synopsis/Expectation.pm -rw-r--r-- 1 root root 1517 Jul 25 02:00 /usr/share/perl5/vendor_perl/Test/Synopsis/Expectation/Pod.pm test@fedora-39:~/rpmbuild/SPECS $ rpm -q -lv -p ../RPMS/noarch/perl-Test-Synopsis-Expectation-tests-0.12-1.fc39.noarch.rpm drwxr-xr-x 2 root root 0 Jul 25 02:00 /usr/libexec/perl-Test-Synopsis-Expectation drwxr-xr-x 2 root root 0 Jul 25 02:00 /usr/libexec/perl-Test-Synopsis-Expectation/t -rwxr-xr-x 1 root root 150 Jul 25 02:00 /usr/libexec/perl-Test-Synopsis-Expectation/t/00_compile.t -rwxr-xr-x 1 root root 577 Jul 25 02:00 /usr/libexec/perl-Test-Synopsis-Expectation/t/01_basic.t -rwxr-xr-x 1 root root 693 Jul 25 02:00 /usr/libexec/perl-Test-Synopsis-Expectation/t/02_fail.t -rwxr-xr-x 1 root root 373 Jul 25 02:00 /usr/libexec/perl-Test-Synopsis-Expectation/t/03_multiple_file.t -rwxr-xr-x 1 root root 271 Jul 25 02:00 /usr/libexec/perl-Test-Synopsis-Expectation/t/04_yadayada.t -rwxr-xr-x 1 root root 295 Jul 25 02:00 /usr/libexec/perl-Test-Synopsis-Expectation/t/05_prepared.t -rwxr-xr-x 1 root root 451 Jul 25 02:00 /usr/libexec/perl-Test-Synopsis-Expectation/t/06_wrapped_brace.t -rwxr-xr-x 1 root root 292 Jul 25 02:00 /usr/libexec/perl-Test-Synopsis-Expectation/t/07_multi_part_synopsis.t -rwxr-xr-x 1 root root 330 Jul 25 02:00 /usr/libexec/perl-Test-Synopsis-Expectation/t/08_ignore.t -rwxr-xr-x 1 root root 375 Jul 25 02:00 /usr/libexec/perl-Test-Synopsis-Expectation/t/09_no_test.t drwxr-xr-x 2 root root 0 Jul 25 02:00 /usr/libexec/perl-Test-Synopsis-Expectation/t/resources -rw-r--r-- 1 root root 117 Dec 16 2014 /usr/libexec/perl-Test-Synopsis-Expectation/t/resources/less.pod -rwxr-xr-x 1 root root 117 Jul 25 02:00 /usr/libexec/perl-Test-Synopsis-Expectation/test File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Test-Synopsis-Expectation-0.12-1.fc39.noarch.rpm | sort -f | uniq -c 1 perl(:VERSION) >= 5.8.5 1 perl(ExtUtils::Manifest) 1 perl(parent) 1 perl(Pod::Simple::Methody) 1 perl(PPI::Tokenizer) 1 perl(strict) 1 perl(Test::Builder::Module) 1 perl(Test::More) 1 perl(Test::Synopsis::Expectation::Pod) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 TODO: Constrain 'perl(Test::More)' with '>= 0.98' (META.json:54). $ rpm -q --requires -p ../RPMS/noarch/perl-Test-Synopsis-Expectation-tests-0.12-1.fc39.noarch.rpm | sort -f | uniq -c 1 /usr/bin/perl 1 /usr/bin/sh 1 perl(File::Spec::Functions) 1 perl(FindBin) 1 perl(strict) 1 perl(Test::Builder::Tester) 1 perl(Test::More) 1 perl(Test::Synopsis::Expectation) 1 perl(warnings) 1 perl-Test-Harness 1 perl-Test-Synopsis-Expectation = 0.12-1.fc39 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 TODO: Constrain 'perl(Test::More)' with '>= 0.98' (META.json:62). $ rpm -q --provides -p ../RPMS/noarch/perl-Test-Synopsis-Expectation-0.12-1.fc39.noarch.rpm | sort -f | uniq -c 1 perl(Test::Synopsis::Expectation) = 0.12 1 perl(Test::Synopsis::Expectation::Pod) 1 perl(Test::Synopsis::Expectation::Sandbox) 1 perl-Test-Synopsis-Expectation = 0.12-1.fc39 $ rpm -q --provides -p ../RPMS/noarch/perl-Test-Synopsis-Expectation-tests-0.12-1.fc39.noarch.rpm | sort -f | uniq -c 1 perl-Test-Synopsis-Expectation-tests = 0.12-1.fc39 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Test-Synopsis-Expectation-* Binary dependencies are resolvable. Ok. The package builds in Fedora Rawhide <https://koji.fedoraproject.org/koji/taskinfo?taskID=103884195>. Ok. The package is in line with Fedora and Perl packaging guidelines. Please consider fixing the TODO items before building this package. Package is APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-Synopsis-Expectation |