Bug 2225451

Summary: Error parsing tox.ini for OSP 18 jobs
Product: Red Hat OpenStack Reporter: Szymon Datko <sdatko>
Component: python-oslo-serializationAssignee: Hervé Beraud <hberaud>
Status: CLOSED MIGRATED QA Contact: Nobody <nobody>
Severity: medium Docs Contact:
Priority: medium    
Version: 18.0 (Zed)CC: apevec, lhh, lmiccini, morazi, njohnston
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: python-oslo-serialization-5.1.1-18.0.20230726084902.b4be3a4.el9ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-01-19 07:16:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Szymon Datko 2023-07-25 10:55:50 UTC
Hello,

we observe a failure in PEP8 job executed as part of Component CI for OSP 18

```
2023-07-20 00:38:10.955922 | TASK [tox : Run tox without tests]
2023-07-20 00:38:21.523038 | container | using tox.ini: /home/zuul/src/code.engineering.redhat.com/oslo.serialization/tox.ini (pid 663)
2023-07-20 00:38:21.540945 | container | Traceback (most recent call last):
2023-07-20 00:38:21.540999 | container |   File "/usr/bin/tox", line 8, in <module>
2023-07-20 00:38:21.541012 | container |     sys.exit(cmdline())
2023-07-20 00:38:21.541020 | container |   File "/opt/tox/lib64/python3.9/site-packages/tox/session/__init__.py", line 44, in cmdline
2023-07-20 00:38:21.542440 | container |     main(args)
2023-07-20 00:38:21.542463 | container |   File "/opt/tox/lib64/python3.9/site-packages/tox/session/__init__.py", line 65, in main
2023-07-20 00:38:21.542491 | container |     config = load_config(args)
2023-07-20 00:38:21.542502 | container |   File "/opt/tox/lib64/python3.9/site-packages/tox/session/__init__.py", line 81, in load_config
2023-07-20 00:38:21.542545 | container |     config = parseconfig(args)
2023-07-20 00:38:21.542554 | container |   File "/opt/tox/lib64/python3.9/site-packages/tox/config/__init__.py", line 299, in parseconfig
2023-07-20 00:38:21.542629 | container |     ParseIni(config, config_file, content)
2023-07-20 00:38:21.542638 | container |   File "/opt/tox/lib64/python3.9/site-packages/tox/config/__init__.py", line 1323, in __init__
2023-07-20 00:38:21.542871 | container |     raise tox.exception.ConfigError(
2023-07-20 00:38:21.542888 | container | tox.exception.ConfigError: ConfigError: cover failed with not enough values to unpack (expected 2, got 1) at Traceback (most recent call last):
2023-07-20 00:38:21.542898 | container |   File "/opt/tox/lib64/python3.9/site-packages/tox/config/__init__.py", line 1299, in run
2023-07-20 00:38:21.542906 | container |     results[name] = cur_self.make_envconfig(name, section, subs, config)
2023-07-20 00:38:21.542915 | container |   File "/opt/tox/lib64/python3.9/site-packages/tox/config/__init__.py", line 1479, in make_envconfig
2023-07-20 00:38:21.542924 | container |     res = meth(env_attr.name, env_attr.default, replace=replace)
2023-07-20 00:38:21.542932 | container |   File "/opt/tox/lib64/python3.9/site-packages/tox/config/__init__.py", line 1718, in getdict_setenv
2023-07-20 00:38:21.542940 | container |     definitions = self._getdict(value, default=default, sep=sep, replace=replace)
2023-07-20 00:38:21.542954 | container |   File "/opt/tox/lib64/python3.9/site-packages/tox/config/__init__.py", line 1738, in _getdict
2023-07-20 00:38:21.542962 | container |     name, value = line.split("=", 1)
2023-07-20 00:38:21.542970 | container | ValueError: not enough values to unpack (expected 2, got 1)
```

I suspect the problem may be related to wrong indentation in line 24 in tox.ini file.

You can use this change for debugging the issue.
https://code.engineering.redhat.com/gerrit/c/oslo.serialization/+/445370

Yours,
Szymon

Comment 4 Szymon Datko 2023-07-25 15:32:21 UTC
@Herve: I do not know, I did not create the downstream branch, I am just setting the Component CI jobs and reporting the problem.

I am sure that cherry-picking this: https://review.opendev.org/c/openstack/oslo.serialization/+/887141 to downstream repo will resolve the issue (I just checked that in the change listed in original post).

Regarding the wrong constraints: I guess the dowstream repository was simply not synced, there was upstream change for this: https://review.opendev.org/c/openstack/oslo.serialization/+/875178

I do not know who is responsible for that either, hence I opened the bugzilla ;-)

Comment 7 Hervé Beraud 2023-07-26 11:27:19 UTC
Fixed in version python-oslo-serialization-5.1.1-18.0.20230726084902.b4be3a4.el9osttrunk

https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=2612216

Even if this new version is not officially released it fixed the gerrit issue described in the description of this bug.