Bug 2225471

Summary: 389-ds-base FTBFS with rust-1.71.0
Product: Red Hat Enterprise Linux 9 Reporter: Tuomo Soini <tis>
Component: rustAssignee: Josh Stone <jistone>
Status: CLOSED ERRATA QA Contact: Jesus Checa <jchecahi>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: CentOS StreamCC: bstinson, jwboyer, sipoyare
Target Milestone: rcKeywords: Bugfix, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rust-1.71.0-2.el9 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 2227084 (view as bug list) Environment:
Last Closed: 2023-11-07 08:32:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2227084    
Deadline: 2023-08-14   

Description Tuomo Soini 2023-07-25 11:39:39 UTC
Description of problem:

389-ds-base-2.3.4-2.el9 and 2.3.4-3.el9 both FTBFS with rust-1.71.0.

error: using `.borrow()` on a double reference, which returns `&concread::cowcell::CowCellReadTxn<CacheStats>` instead of borrowing the inner t
ype
  --> librslapd/src/cache.rs:60:28
   |
60 |     let stats = stat_rguard.borrow();
   |                            ^^^^^^^^^
   |
note: the lint level is defined here
  --> librslapd/src/lib.rs:1:9
   |
1  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(suspicious_double_ref_op)]` implied by `#[deny(warnings)]`
error: could not compile `librslapd` (lib) due to previous error

This is rust issue https://github.com/rust-lang/rust/issues/112489

Comment 1 Josh Stone 2023-07-25 15:55:48 UTC
I do not recommend deny(warnings) in production builds, since we rebase frequently and there may always be new warnings -- whether or not they are false positives.

Still, I can see about backporting the upstream fix for this.

Comment 8 errata-xmlrpc 2023-11-07 08:32:07 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (rust bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:6415