Bug 222575 (pear-ElementGrid)

+ rpmlint output (none)
+ right package name (follows PEAR package naming scheme)
+ build for noarch
+ spec file name = %{name}.spec
+ package version = tarball version
+ uses 1%{?dist} release
+ web site url checked: http://pear.php.net/package/HTML_QuickForm_ElementGrid
+ source file url checked
+ LGPG license
? missing license file
+ requires: php-pear(PEAR)
- requires: php >= 4.3.0 (not sure for this as php-pear requires php yet but
Wiki page says a PEAR package MUST requires it)
+ requires: php-pear(HTML_QuickForm) >= 3.2.5 (as written in PEAR XML package
description)
+ requires: php-pear(HTML_Table) >= 1.7.5 (as written in PEAR XML package
description)
+ provides: php-pear(HTML_QuickForm_ElementGrid) = %{version}
+ uses '%setup -q -c' as suggested in PEAR additional hints
+ uses PEAR macros
+ uses recommended scriptlets for registering and unregistering the module
+ written in english (not my native language so i hope all is OK)
+ md5 of source file same as the one of the source file on the official web site
+ build and installed without problem on fc6
+ sample elementGrid.php tested successfully
+ no duplicate files
+ uses %defattr(-,root,root,-)
+ doesn't own %{pear_phpdir}/HTML/QuickForm directory
? group should be Development/Libraries not Development/Languages
+ buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

+ build with mock (fc6 i386)
- a new version is released (0.1.0) since a few days

Let me go ahead and ack this, since Sebastien isn't sponsored yet.

Nothing from rpmlint; everything looks good.

* source files match upstream:
26a09d192dfcc27a250b940943b02e0d1d0c59d0329a5350c915d41164e901ba
HTML_QuickForm_ElementGrid-0.1.0.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
O latest version is 0.1.1.
  This came out way after you submitted the review; any reason for not
  packaging it instead?
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   php-pear(HTML_QuickForm_ElementGrid) = 0.1.0
   php-pear-HTML-QuickForm-ElementGrid = 0.1.0-1.fc7
  =
   /bin/sh
   /usr/bin/pear
   php-pear(HTML_QuickForm) >= 3.2.5
   php-pear(HTML_Table) >= 1.7.5
   php-pear(PEAR)

* %check is not present; not test suite upstream.
* owns the directories it creates.
  (/usr/share/pear/HTML/QuickForm is owned by a dependency)
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

New Package CVS Request
=======================
Package Name: php-pear-HTML-QuickForm-ElementGrid
Short Description: Meta-element which holds any other element in a grid
Owners: chris.stone
Branches: FC-6 FC-5 EL-5
InitialCC: 

CVS done

0.1.1 pushed, thanks for the reviews!