Bug 222598 (php-pecl-radius)
Summary: | Review Request: php-pecl-radius - Radius client library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christopher Stone <chris.stone> |
Component: | Package Review | Assignee: | Remi Collet <fedora> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora, matthias |
Target Milestone: | --- | Flags: | fedora:
fedora-review+
wtogami: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-03-13 08:04:59 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Christopher Stone
2007-01-15 02:12:30 UTC
I wanted to take a quick look at this package, but it seems that tkmame.retrogames.com is unavailable at the moment. Unfortunately not the most reliable server. Seems to be back up now. What about using the new provides to ensure ABI compatibility with PHP For example %if %{?php_zend_api}0 # for fedora >= 6 Requires: php(zend-abi) = %{php_zend_api} Requires: php(api) = %{php_core_api} %else # for fedora <= 5 Requires: php-api = %{php_apiver} %endif As for php-pear packages, php-pecl tarball have a package.xml outside any directory. So, you must use %prep %setup -c -q cd radius-%{version} I finally succeed to install a local radius server and to have a working test for this extension, so, === REVIEW === :) source files match upstream: 3d48ccb9486b9e8839d814d7ff318091 radius-1.2.4.tgz :) package meets naming and packaging guidelines. :( specfile is properly named, is cleanly written and uses macros consistently. => see comment #4 :) dist tag is present. :) build root is correct (second form). :) license field matches the actual license. :) license is open source-compatible (BSD). :) latest version is being packaged (1.2.4) :) BuildRequires are proper. :) %clean is present. :) package builds in mock (FC6). :) package installs properly :) rpmlint is silent. :) final provides are sane: config(php-pecl-radius) = 1.2.4-1.fc7 php-pecl(radius) = 1.2.4-1.fc7 radius.so()(64bit) php-pecl-radius = 1.2.4-1.fc7 :/ final Requires are sane: => see comment # 3 :) %check is not present; :) owns the directories it creates :) no duplicates in %files. :) file permissions are appropriate. :) no scriplet :) code, not content. :) documentation is small, so no -docs subpackage is necessary. :) %docs are not necessary for the proper functioning of the package. Don't know if "release" is need in virtual provide 'php-pecl(radius)' ? perl and php-pear virtual provide never used it. Should : comment #3 Must: comment #4 Indeed, my php-pecl-xdebug package will also need to be fixed. Thanks for spotting this. Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pecl-radius.spec SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pecl-radius-1.2.4-2.src.rpm %changelog * Sun Mar 11 2007 Christopher Stone <chris.stone> 1.2.4-2 - Use new ABI check for FC-6 - Create directory to untar sources - Remove %%{release} from Provides Option -n to %setup is not needed... but not a issue. == APPROVED == New Package CVS Request ======================= Package Name: php-pecl-radius Short Description: Radius client library Owners: chris.stone Branches: FC-5 FC6 devel InitialCC: - Fixed -n option - Imported and built on FC-5 FC-6 and devel Thanks for the review! :D Package Change Request ====================== Package Name: php-pecl-radius New Branches: EL-5 |