Bug 2226736

Summary:	incompatible numpy update (1.22.0->1.24.3) caused test failures in mrcfile
Product:	[Fedora] Fedora	Reporter:	Dominik 'Rathann' Mierzejewski <dominik>
Component:	numpy	Assignee:	Gwyn Ciesla <gwync>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	37	CC:	cstratak, gwync, orion, rdieter, tomspur
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-07-26 20:00:57 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dominik 'Rathann' Mierzejewski 2023-07-26 11:36:52 UTC

Since numpy-1.24.3-1.fc37 update was pushed to F37+ back in May, python-mrcfile has been failing in its test suite:
https://koschei.fedoraproject.org/package/python-mrcfile?collection=f37


Reproducible: Always

Steps to Reproduce:
1. Run python-mrcfile test suite with numpy 1.24.0 or later installed

Actual Results:  
> ======================================================================
> FAIL: test_data_is_not_copied_unnecessarily (tests.test_bzip2mrcfile.Bzip2MrcFileTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/<<PKGBUILDDIR>>/tests/test_mrcobject.py", line 341, in test_data_is_not_copied_unnecessarily
>     assert self.mrcobject.data is data
> AssertionError
and other failures.

Expected Results:  
Tests pass.

Upstream issue points to incompatible behaviour change in numpy.
https://github.com/ccpem/mrcfile/issues/49

Could you test all numpy consumers in COPR before doing updates in the future? That can be easily automated, see Karolina Surma's talk at the last DevConf for details:
https://devconfcz2023.sched.com/event/1MYlI/fedora-package-update-assess-its-impact-in-copr
https://www.youtube.com/watch?v=nS0Z1OilOas (starts around 07:37:00 mark)

Comment 1 Gwyn Ciesla 2023-07-26 20:00:57 UTC

Apologies, I hadn't run into something like this with numpy before. I'll do that in the future.