Bug 2226762
| Summary: | Review Request: lib2geom - Easy to use 2D geometry library in C++ | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Felix Wang <topazus> | ||||||
| Component: | Package Review | Assignee: | Gwyn Ciesla <gwync> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | gwync, package-review | ||||||
| Target Milestone: | --- | Flags: | gwync:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2023-07-28 07:48:03 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Felix Wang
2023-07-26 12:38:53 UTC
@gwync Hello Gwyn Ciesla, would you mind to spare some time for reviewing this package? It is also the one of the dependency of inkscape. https://src.fedoraproject.org/rpms/inkscape/blob/rawhide/f/inkscape.spec#_35 build option of WITH_INTERNAL_2GEOM, https://gitlab.com/inkscape/inkscape/-/blob/master/CMakeScripts/DefineDependsandFlags.cmake#L161-173 Thanks, will do! update: comment out to not apply the patch, as I thought wrongly it can fix elliptical-arc-test test fail and did not tested it before. skip elliptical-arc-test test on aarch64, ppc64le and s390x. Spec URL: https://topazus.fedorapeople.org/rpms/lib2geom.spec SRPM URL: https://topazus.fedorapeople.org/rpms/lib2geom-1.3-1.fc39.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=103960010 Created attachment 1980165 [details]
The .spec file difference from Copr build 6213990 to 6214664
Looks good. The only issues I see are: rpmlint thought the patch in the first spec wasn't applied but it was. You probably should file a bug for that. You're using a glob for the shared library listing. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files Instead of %{_libdir}/lib2geom.so.* I'd recommend %{_libdir}/lib2geom.so.1.* I'll do some local testing with Inkscape and get back to you. Seems good. I can approve once the above is fixed. > rpmlint thought the patch in the first spec wasn't applied but it was. You probably should file a bug for that. The bug was already filed some days before. https://github.com/rpm-software-management/rpmlint/issues/1074 > Instead of %{_libdir}/lib2geom.so.* I'd recommend %{_libdir}/lib2geom.so.1.* Done. Spec URL: https://topazus.fedorapeople.org/rpms/lib2geom.spec SRPM URL: https://topazus.fedorapeople.org/rpms/lib2geom-1.3-1.fc39.src.rpm Created attachment 1980202 [details]
The .spec file difference from Copr build 6214664 to 6215351
Excellent, thank you! APPROVED. Let me know when it's in rawhide and I'll rebuild inkscape with it. The Pagure repository was created at https://src.fedoraproject.org/rpms/lib2geom FEDORA-2023-bb3372c969 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-bb3372c969 FEDORA-2023-bb3372c969 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. (In reply to Gwyn Ciesla from comment #10) > Excellent, thank you! > > APPROVED. > > Let me know when it's in rawhide and I'll rebuild inkscape with it. Thanks for the review work. I have published it into Fedora rawhide. |