Bug 2227039
| Summary: | Review Request: rust-listenfd - Simple library to work with listenfds passed from the outside | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Kalev Lember <klember> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | klember, package-review |
| Target Milestone: | --- | Flags: | klember:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/listenfd | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-09-01 19:52:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabio Valentini
2023-07-27 14:23:44 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=104012426 This is an unretirement request. I would need this crate to enable running tests for the warp crate. Copr build: https://copr.fedorainfracloud.org/coprs/build/6217411 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227039-rust-listenfd/fedora-rawhide-x86_64/06217411-rust-listenfd/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Looks nice and clean and the only changes to the package that was in Fedora before the retirement is the version bump from 1.0.0 to 1.0.1 and re-generating the spec file with newer rust2rpm. Package APPROVED. Thanks for the review! https://pagure.io/releng/issue/11650 Unretired, updated, built, and built warp with re-enabled test suite. Thanks! https://bodhi.fedoraproject.org/updates/FEDORA-2023-a21d5cfbe6 |