Bug 2227084

Summary: 389-ds-base FTBFS with rust-1.71.0
Product: Red Hat Enterprise Linux 8 Reporter: Josh Stone <jistone>
Component: rust-toolsetAssignee: Josh Stone <jistone>
Status: VERIFIED --- QA Contact: Jesus Checa <jchecahi>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: CentOS StreamCC: bstinson, jchecahi, jwboyer, sipoyare, tis
Target Milestone: rcKeywords: Bugfix, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rust-toolset-rhel8-8090020230727010609.2227d48a Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: 2225471 Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2225471    
Bug Blocks:    
Deadline: 2023-08-14   

Description Josh Stone 2023-07-27 18:20:42 UTC 
Cloning to el8 for bugfix parity.

+++ This bug was initially created as a clone of Bug #2225471 +++

Description of problem:

389-ds-base-2.3.4-2.el9 and 2.3.4-3.el9 both FTBFS with rust-1.71.0.

error: using `.borrow()` on a double reference, which returns `&concread::cowcell::CowCellReadTxn<CacheStats>` instead of borrowing the inner t
ype
  --> librslapd/src/cache.rs:60:28
   |
60 |     let stats = stat_rguard.borrow();
   |                            ^^^^^^^^^
   |
note: the lint level is defined here
  --> librslapd/src/lib.rs:1:9
   |
1  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(suspicious_double_ref_op)]` implied by `#[deny(warnings)]`
error: could not compile `librslapd` (lib) due to previous error

This is rust issue https://github.com/rust-lang/rust/issues/112489

--- Additional comment from Josh Stone on 2023-07-25 08:55:48 PDT ---

I do not recommend deny(warnings) in production builds, since we rebase frequently and there may always be new warnings -- whether or not they are false positives.

Still, I can see about backporting the upstream fix for this.