Bug 2227208

Summary:	[regression] thin_delta doesn't accept --thin option
Product:	Red Hat Enterprise Linux 9	Reporter:	Filip Suba <fsuba>
Component:	device-mapper-persistent-data	Assignee:	Ming-Hung Tsai <mtsai>
Status:	CLOSED ERRATA	QA Contact:	Filip Suba <fsuba>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	9.3	CC:	agk, heinzm, lvm-team, mcsontos, msnitzer, thornber
Target Milestone:	rc	Keywords:	Triaged
Target Release:	---	Flags:	pm-rhel: mirror+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	device-mapper-persistent-data-1.0.6-1.el9	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-11-07 08:56:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Filip Suba 2023-07-28 10:27:00 UTC

Description of problem:
Latest release of thin_delta returns "unknown option" error message when using --thin option.


Version-Release number of selected component (if applicable):
device-mapper-persistent-data-1.0.5-1.el9


How reproducible:
always


Steps to Reproduce:
1. thin_delta /dev/mapper/vgtest-swapvol --thin1 '1' --thin2 '9'
2.
3.

Actual results:
thin_delta /dev/mapper/vgtest-swapvol --thin1 '1' --thin2 '9'
unknown option


Expected results:
thin_delta /dev/mapper/vgtest-swapvol --thin1 '1' --thin2 '9'
<superblock uuid="" time="0" transaction="10" data_block_size="128" nr_data_blocks="1600">
 <diff left="1" right="9">
  <different begin="0" length="2"/>
  <different begin="13" length="17"/>
  <different begin="128" length="1"/>
  <different begin="191" length="1"/>
 </diff>
</superblock>


Additional info:

Comment 1 Ming-Hung Tsai 2023-08-09 06:56:11 UTC

Fixed upstream: https://github.com/jthornber/thin-provisioning-tools/commit/ee74c54521

Awaiting for the next release.

Comment 2 Ming-Hung Tsai 2023-08-09 07:58:50 UTC

Fixed in v1.0.6 upstream. Added two more functional tests to make sure the options work as expected.

```
# cargo test [--release]
...
Running tests/thin_delta.rs 

test test_same_dev_id ... ok
test test_same_root ... ok
```

Comment 6 Filip Suba 2023-08-24 14:08:23 UTC

Verified with device-mapper-persistent-data-1.0.6-1.el9.

Comment 8 errata-xmlrpc 2023-11-07 08:56:16 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (device-mapper-persistent-data bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:6701