Bug 2227230

Summary:	pcs does not prevent disabling ATB when it can break SBD
Product:	Red Hat Enterprise Linux 9	Reporter:	Tomas Jelinek <tojeline>
Component:	pcs	Assignee:	Peter Romancik <promanci>
Status:	CLOSED MIGRATED	QA Contact:	cluster-qe <cluster-qe>
Severity:	high	Docs Contact:
Priority:	high
Version:	9.0	CC:	cluster-maint, idevat, mlisik, mmazoure, mpospisi, omular, tojeline
Target Milestone:	rc	Keywords:	MigratedToJIRA, Triaged
Target Release:	9.4
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: User tries to disable auto_tie_breaker when it is needed due to sbd Consequence: auto_tie_breaker is disabled despite it being needed by sbd Fix: Fixed check to see if auto_tie_breaker is needed when updating quorum options Result: Error message is shown in case user tries to disable auto_tie_breaker when it is needed due to sbd	Story Points:	---
Clone Of:
Clones:	2227233 (view as bug list)		Environment:
Last Closed:	2023-09-22 20:27:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2227233

Description Tomas Jelinek 2023-07-28 12:54:53 UTC

Description of problem:
When SBD with no disks is enabled in a cluster with even numerb of nodes, auto_tie_breaker must be enabled in orded for SBD to work correctly. Pcs should prevent disabling auto_tie_breaker in this case.


Version-Release number of selected component (if applicable):
pcs-0.11.6


How reproducible:
always, easily


Steps to Reproduce:
1. create a cluster with two nodes
2. enable SBD: 'pcs stonith sbd enable'
3. try to disable ATB: 


Actual results:
In step 2, pcs informs the user that ATB must be enabled. Yet, in step 3, pcs is fine with disabling ATB.


Expected results:
Pcs prevents disabling SBD in step 3.

Comment 2 Peter Romancik 2023-08-30 10:49:58 UTC

Upstream commit: https://github.com/ClusterLabs/pcs/commit/efefd59041851f4b35d876bb72659b425749a223

Updated commands:
  * pcs quorum update

Test Environment: a cluster with enabled sbd with no disks, even number of nodes in the cluster

Test:
# pcs quorum update auto_tie_breaker=0
Error: Unable to disable auto_tie_breaker, SBD fencing would have no effect, use --force to override
Error: Errors have occurred, therefore pcs is unable to continue

Comment 3 RHEL Program Management 2023-09-22 20:25:05 UTC

Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug.

Comment 4 RHEL Program Management 2023-09-22 20:27:00 UTC

This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.