Bug 222743
Summary: | gfs_grow gets the rgindex out of order | ||||||
---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 5 | Reporter: | Robert Peterson <rpeterso> | ||||
Component: | gfs-utils | Assignee: | Robert Peterson <rpeterso> | ||||
Status: | CLOSED ERRATA | QA Contact: | GFS Bugs <gfs-bugs> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | 5.0 | CC: | adas, rkenna | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | RHBA-2007-0576 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2007-11-07 17:57:42 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 222748 | ||||||
Attachments: |
|
Description
Robert Peterson
2007-01-15 22:47:01 UTC
The problem is easily fixed. Back in March 2006 when I was testing changes to gfs_fsck rg repair, I noticed this problem and created this patch to fix it in RHEL4: --- main.c.~1~ 2005-01-04 04:07:07.000000000 -0600 +++ main.c 2006-03-30 11:18:34.000000000 -0600 @@ -669,7 +669,7 @@ make_rgrp(uint64_t offset, uint64_t size rgl->rg.rg_header.mh_format = GFS_FORMAT_RG; rgl->rg.rg_free = rgl->ri.ri_data; - osi_list_add(&rgl->list, &rglist_new); + osi_list_add_prev(&rgl->list, &rglist_new); return offset + size; } The patch unfortunately never made it to RHEL5 or anywhere. This should be fixed so customers aren't confused by it. Created attachment 145848 [details]
RHEL5 patch to fix the problem
Unit tested on trin-10: I used "gfs2_edit -p rgindex" to print the rg index after the mkfs and after the gfs_grow. The dump of the rg index was bad before the fix and correct after the fix was applied and the same commands were rerun to make and grow the file system. Committed to CVS at HEAD and RHEL5 (not RHEL50). Changing status to modified. Fixing product name. Cluster Suite components were integrated into Enterprise Linux for verion 5.0. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2007-0576.html |