Bug 2227543

Summary: Review Request: rust-struct-patch-derive - Library that helps you implement partial updates for your structs
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: Davide Cavalca <davide>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: davide, package-review
Target Milestone: ---Flags: davide: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/struct-patch-derive
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-07-31 06:27:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2227545    

Description Fabio Valentini 2023-07-30 15:57:25 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-struct-patch-derive.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-struct-patch-derive-0.2.3-1.fc38.src.rpm

Description:
A library that helps you implement partial updates for your structs.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-07-30 15:57:27 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=104142340

Comment 2 Fedora Review Service 2023-07-30 16:03:42 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6223641
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227543-rust-struct-patch-derive/fedora-rawhide-x86_64/06223641-rust-struct-patch-derive/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Davide Cavalca 2023-07-30 16:38:07 UTC
Taking this review

Comment 4 Davide Cavalca 2023-07-30 16:39:34 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
~ license file is included with %license in %files (included separately from upstream for now)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Comment 5 Fedora Admin user for bugzilla script actions 2023-07-30 19:23:53 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-struct-patch-derive

Comment 6 Fedora Update System 2023-07-31 06:25:10 UTC
FEDORA-2023-375c7074df has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-375c7074df

Comment 7 Fedora Update System 2023-07-31 06:27:18 UTC
FEDORA-2023-375c7074df has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.