Bug 2227555

Summary: Review Request: golang-github-zeebo-xxh3 - XXH3 algorithm in Go
Product: [Fedora] Fedora Reporter: Pavel Solovev <daron439>
Component: Package ReviewAssignee: Mikel Olasagasti Uranga <mikel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: mikel, package-review
Target Milestone: ---Flags: mikel: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-08-02 15:51:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
The .spec file difference from Copr build 6223692 to 6234858 none

Description Pavel Solovev 2023-07-30 16:40:17 UTC
Spec URL: https://solopasha.fedorapeople.org/for-review/golang-github-zeebo-xxh3.spec
SRPM URL: https://solopasha.fedorapeople.org/for-review/golang-github-zeebo-xxh3-1.0.2-1.fc39.src.rpm
Description: XXH3 algorithm in Go
Fedora Account System Username: solopasha

Comment 1 Mikel Olasagasti Uranga 2023-08-02 13:59:06 UTC
> BuildError: The following noarch package built differently on different architectures: golang-github-zeebo-xxh3-devel-1.0.2-1.fc39.noarch.rpm
> rpmdiff output was:
> removed     REQUIRES golang(github.com/klauspost/cpuid/v2)  

https://koji.fedoraproject.org/koji/taskinfo?taskID=104264114

Check golang-github-minio-md5-simd.spec to see how this can be solved.

Comment 3 Fedora Review Service 2023-08-02 14:21:28 UTC
Created attachment 1981328 [details]
The .spec file difference from Copr build 6223692 to 6234858

Comment 4 Mikel Olasagasti Uranga 2023-08-02 15:02:10 UTC
I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 5 Fedora Admin user for bugzilla script actions 2023-08-02 15:31:09 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-zeebo-xxh3

Comment 6 Fedora Update System 2023-08-02 15:48:53 UTC
FEDORA-2023-ad321259ae has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-ad321259ae

Comment 7 Fedora Update System 2023-08-02 15:51:05 UTC
FEDORA-2023-ad321259ae has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.