Bug 2227579

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=104156294

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GNU General Public License v2.0 or later [obsolete FSF postal
     address (Temple Place)]", "Unknown or generated", "GNU General Public
     License, Version 2". 306 files have unknown license. Detailed output
     of licensecheck in
     /home/FedoraPackaging/reviews/linux-air-combat/2227579-linux-air-
     combat/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 266240 bytes in 7 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in linux-
     air-combat-data
[ ]: Package functions as described.
[x]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: linux-air-combat-09p15-1.fc38.x86_64.rpm
          linux-air-combat-data-09p15-1.fc38.noarch.rpm
          linux-air-combat-debuginfo-09p15-1.fc38.x86_64.rpm
          linux-air-combat-debugsource-09p15-1.fc38.x86_64.rpm
          linux-air-combat-09p15-1.fc38.src.rpm
=========================================== rpmlint session starts ==========================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpk0yqqgrn')]
checks: 31, packages: 5

linux-air-combat.x86_64: W: no-manual-page-for-binary lac
linux-air-combat-data.noarch: W: no-documentation
linux-air-combat-data.noarch: W: files-duplicate /usr/share/lac/textures/panzer2_.tga /usr/share/lac/textures/panzer1_.tga
linux-air-combat-data.noarch: W: files-duplicate /usr/share/lac/textures/ship_fra.tga /usr/share/lac/textures/ship2_fr.tga
linux-air-combat.x86_64: W: desktopfile-without-binary /usr/share/applications/lac.desktop sh
linux-air-combat.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/bin/lac
============ 5 packages and 0 specfiles checked; 0 errors, 6 warnings, 0 badness; has taken 8.8 s ===========




Rpmlint (debuginfo)
-------------------
Checking: linux-air-combat-debuginfo-09p15-1.fc38.x86_64.rpm
=========================================== rpmlint session starts ==========================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpws9b0qs0')]
checks: 31, packages: 1

============ 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.9 s ===========





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 4

linux-air-combat.x86_64: W: unused-direct-shlib-dependency /usr/bin/lac /lib64/libglut.so.3
linux-air-combat.x86_64: W: no-manual-page-for-binary lac
linux-air-combat-data.noarch: W: no-documentation
linux-air-combat-data.noarch: W: files-duplicate /usr/share/lac/textures/panzer2_.tga /usr/share/lac/textures/panzer1_.tga
linux-air-combat-data.noarch: W: files-duplicate /usr/share/lac/textures/ship_fra.tga /usr/share/lac/textures/ship2_fr.tga
linux-air-combat.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/bin/lac
 4 packages and 0 specfiles checked; 0 errors, 6 warnings, 0 badness; has taken 5.6 s 



Source checksums
----------------
https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt :
  CHECKSUM(SHA256) this package     : 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643
  CHECKSUM(SHA256) upstream package : 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643
https://sourceforge.net/projects/linuxaircombat/files/Choose%20Your%20Platform/Most%20LINUX%20Desktops%20%28in%20the%20global%20usr%20filesystem%20for%20all%20users%29/Lac09p15.tar.gz :
  CHECKSUM(SHA256) this package     : 7a7fded2bf6f38c8a2226d81abf93a13c20d92521c4c04e6e72eafb875e5db80
  CHECKSUM(SHA256) upstream package : 7a7fded2bf6f38c8a2226d81abf93a13c20d92521c4c04e6e72eafb875e5db80


Requires
--------
linux-air-combat (rpmlib, GLIBC filtered):
    libGL.so.1()(64bit)
    libGLU.so.1()(64bit)
    libSDL-1.2.so.0()(64bit)
    libSDL_mixer-1.2.so.0()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libglut.so.3()(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    linux-air-combat-data
    rtld(GNU_HASH)

linux-air-combat-data (rpmlib, GLIBC filtered):

linux-air-combat-debuginfo (rpmlib, GLIBC filtered):

linux-air-combat-debugsource (rpmlib, GLIBC filtered):



Provides
--------
linux-air-combat:
    application()
    application(lac.desktop)
    linux-air-combat
    linux-air-combat(x86-64)
    metainfo()
    metainfo(com.askmisterwizard.linux_air_combat.metainfo.xml)

linux-air-combat-data:
    linux-air-combat-data

linux-air-combat-debuginfo:
    debuginfo(build-id)
    linux-air-combat-debuginfo
    linux-air-combat-debuginfo(x86-64)

linux-air-combat-debugsource:
    linux-air-combat-debugsource
    linux-air-combat-debugsource(x86-64)



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2227579 -m fedora-38-x86_64
Buildroot used: fedora-38-x86_64
Active plugins: Generic, C/C++, Shell-api
Disabled plugins: Perl, PHP, Ocaml, R, Haskell, Java, Ruby, SugarActivity, fonts, Python
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Initial Comments:
a) Can one add a link to a request to upstream to add a license file?
b) NetworkApi.cpp uses gethostbyname - maybe this can be replaced or a fix requested upstream?