Bug 2227798

Summary:	Customers should check custom Puppet parameters during FFU procedure
Product:	Red Hat OpenStack	Reporter:	Alex Stupnikov <astupnik>
Component:	documentation	Assignee:	kgilliga
Status:	MODIFIED ---	QA Contact:	RHOS Documentation Team <rhos-docs>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	16.2 (Train)	CC:	kgilliga, lbezdick
Target Milestone:	---	Keywords:	Documentation, Triaged
Target Release:	---	Flags:	kgilliga: needinfo? (astupnik) kgilliga: needinfo? (lbezdick)
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Alex Stupnikov 2023-07-31 14:26:34 UTC

Description of problem:

In RHOSP 10->13 upgrade document we had a section explaining steps to verify extra config defined using SECTION/parameter syntax to avoid common problems during FFU procedure when some parameter was added to puppets. https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/13/html-single/fast_forward_upgrades/index#checking-parameters-in-custom-hieradata

Skipping this steps will block FFU procedure with similar error:

<13>Jul 26 10:45:10 puppet-user: Error: Evaluation Error: Error while evaluating a Function Call, Duplicate declaration: Keystone_config[identity/password_hash_algorithm] is already declared at (file: /etc/puppet/modules/keystone/manifests/init.pp, line: 850); cannot redeclare (file: /etc/puppet/modules/keystone/manifests/config.pp, line: 31) (file: /etc/puppet/modules/keystone/manifests/config.pp, line: 31, column: 3) on node somenode.example.com

This section is no longer there for RHOSP 16.2, while it is still a must: https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/16.2/html-single/framework_for_upgrades_13_to_16.2/index

Version-Release number of selected component (if applicable):
RHOSP 16.2

Comment 3 Lukas Bezdicka 2023-08-22 13:34:55 UTC

So I explored the code and for this particular case section "5.15. Checking custom Puppet parameters" would probably have worked.

I suggest taking the section and adding it to 16.2 and 17.1 docs before upgrade prepare. I still think better solution is to ask customers to first take their templates and make them work for clean deploy but they would still have to solve this in the same way.