Bug 222798
Summary: | nfs protocol V3 :write procedure patch | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 4 | Reporter: | Xuui <xur> | ||||||||
Component: | kernel | Assignee: | Peter Staubach <staubach> | ||||||||
Status: | CLOSED ERRATA | QA Contact: | |||||||||
Severity: | medium | Docs Contact: | |||||||||
Priority: | medium | ||||||||||
Version: | 4.4 | CC: | jlayton, steved | ||||||||
Target Milestone: | --- | ||||||||||
Target Release: | --- | ||||||||||
Hardware: | All | ||||||||||
OS: | Linux | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | RHBA-2007-0791 | Doc Type: | Bug Fix | ||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | 2007-11-15 16:17:45 UTC | Type: | --- | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Attachments: |
|
Description
Xuui
2007-01-16 09:16:57 UTC
It seems that the NFS server does not handle zero length WRITE requests correctly. It also does not do much in the way of checking the RPC request to see whether the data, which is supposed to be included in the request, is actually included in the request. Created attachment 147410 [details]
Proposed patch
We have applied your patch,then our tests succeed.thank you for your help. We want to know Whether this patch will apply to the latest kernel or not ? If it will be applied ,our team needn't patch the kernel every time. Thanks Xu Rui Thanx for testing the proposed RHEL-4 patch. No, the current patch will not apply either RHEL-5 or to upstream. I have a patch constructed and tested for RHEL-5 and I am working on testing a patch for upstream. When I get the upstream patch completed, I will post it upstream for NeilB. Then, I will file a bugzilla for the RHEL-5 problem and then send both the RHEL-4 and RHEL-5 patches to rhkernel-list for inclusion into the respective releases. Hi.it is me .I still have some question . According to the RFC 1813 "The size of data must be less than or equal to the value of the wtmax field in the FSINFO reply structure for the file system that contains file. If greater, the server may write only wtmax bytes, resulting in a short write." It shows that when the size of data is greater than the value of the wtmax,server may write only wtmax bytes.however if we use your patch,server will write unsuccessfully in this case.Maybe something wrong? please confirm .thank you! Hmmm. I don't know what "write unsuccessfully" means. However, I do agree, that there is _another_ bug there. An already existing bug, but one that we might as well fix. If the size is limited by NFSSVC_MAXBLKSIZE, then args->count and args->len do not get adjusted correctly. I will add this support and attach another patch when it is ready. Created attachment 148117 [details]
Proposed patch
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. Created attachment 155160 [details]
Proposed patch
Attached the simplified patch which is patterned after the patch which was accepted upstream. This request was evaluated by Red Hat Kernel Team for inclusion in a Red Hat Enterprise Linux maintenance release, and has moved to bugzilla status POST. committed in stream U6 build 55.12. A test kernel with this patch is available from http://people.redhat.com/~jbaron/rhel4/ An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2007-0791.html |