Bug 2227996
| Summary: | Reactivation of nfs4-acl-tools GUI | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Louis.Giannone |
| Component: | libnfs | Assignee: | Xavier Bachelot <xavier> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 38 | CC: | bfields, Louis.Giannone, ross, steved, xavier |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | Bug | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Louis.Giannone
2023-08-01 06:10:41 UTC
Now compiles after modifying .pro for qt5 compatibility Add line QT += widgets After qmake you get this compile command that throws a great number of C++ errors/warnings g++ -c -pipe -O2 -Wall -W -D_REENTRANT -fPIC -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CORE_LIB -I. -I. -isystem /usr/local/include -I../../include -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -I. -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -o nfs4acleditor.o nfs4acleditor.cpp Compiler error messages :
In file included from nfs4acleditor.cpp:34:
nfs4acleditor.h:113:23: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
113 | {NFS4_ACE_READ_DATA, "read data", "r"},
| ^~~~~~~~~~~
nfs4acleditor.h:113:36: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
113 | {NFS4_ACE_READ_DATA, "read data", "r"},
| ^~~
nfs4acleditor.h:114:24: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
114 | {NFS4_ACE_WRITE_DATA, "write data", "w"},
| ^~~~~~~~~~~~
nfs4acleditor.h:114:38: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
114 | {NFS4_ACE_WRITE_DATA, "write data", "w"},
| ^~~
nfs4acleditor.h:115:25: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
115 | {NFS4_ACE_APPEND_DATA, "append data", "a"},
| ^~~~~~~~~~~~~
nfs4acleditor.h:115:40: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
115 | {NFS4_ACE_APPEND_DATA, "append data", "a"},
| ^~~
nfs4acleditor.h:116:21: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
116 | {NFS4_ACE_EXECUTE, "execute", "x"},
| ^~~~~~~~~
nfs4acleditor.h:116:32: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
116 | {NFS4_ACE_EXECUTE, "execute", "x"},
| ^~~
nfs4acleditor.h:117:20: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
117 | {NFS4_ACE_DELETE, "delete", "d" },
| ^~~~~~~~
nfs4acleditor.h:117:30: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
117 | {NFS4_ACE_DELETE, "delete", "d" },
| ^~~
nfs4acleditor.h:118:29: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
118 | {NFS4_ACE_READ_ATTRIBUTES, "read attrs", "t"},
| ^~~~~~~~~~~~
nfs4acleditor.h:118:43: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
118 | {NFS4_ACE_READ_ATTRIBUTES, "read attrs", "t"},
| ^~~
nfs4acleditor.h:119:30: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
119 | {NFS4_ACE_WRITE_ATTRIBUTES, "write attrs", "T"},
| ^~~~~~~~~~~~~
nfs4acleditor.h:119:45: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
119 | {NFS4_ACE_WRITE_ATTRIBUTES, "write attrs", "T"},
| ^~~
nfs4acleditor.h:120:30: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
120 | {NFS4_ACE_READ_NAMED_ATTRS, "read named attrs", "n"},
| ^~~~~~~~~~~~~~~~~~
nfs4acleditor.h:120:50: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
120 | {NFS4_ACE_READ_NAMED_ATTRS, "read named attrs", "n"},
| ^~~
nfs4acleditor.h:121:31: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
121 | {NFS4_ACE_WRITE_NAMED_ATTRS, "write named attrs", "N"},
| ^~~~~~~~~~~~~~~~~~~
nfs4acleditor.h:121:52: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
121 | {NFS4_ACE_WRITE_NAMED_ATTRS, "write named attrs", "N"},
| ^~~
nfs4acleditor.h:122:22: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
122 | {NFS4_ACE_READ_ACL, "read ACL", "c"},
| ^~~~~~~~~~
nfs4acleditor.h:122:34: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
122 | {NFS4_ACE_READ_ACL, "read ACL", "c"},
| ^~~
nfs4acleditor.h:123:23: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
123 | {NFS4_ACE_WRITE_ACL, "write ACL", "C"},
| ^~~~~~~~~~~
nfs4acleditor.h:123:36: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
123 | {NFS4_ACE_WRITE_ACL, "write ACL", "C"},
| ^~~
nfs4acleditor.h:124:25: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
124 | {NFS4_ACE_WRITE_OWNER, "write owner", "o"},
| ^~~~~~~~~~~~~
nfs4acleditor.h:124:40: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
124 | {NFS4_ACE_WRITE_OWNER, "write owner", "o"},
| ^~~
nfs4acleditor.h:125:25: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
125 | {NFS4_ACE_SYNCHRONIZE, "synchronize", "y"},
| ^~~~~~~~~~~~~
nfs4acleditor.h:125:40: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
125 | {NFS4_ACE_SYNCHRONIZE, "synchronize", "y"},
| ^~~
nfs4acleditor.h:130:28: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
130 | {NFS4_ACE_LIST_DIRECTORY, "list directory", "r"},
| ^~~~~~~~~~~~~~~~
nfs4acleditor.h:130:46: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
130 | {NFS4_ACE_LIST_DIRECTORY, "list directory", "r"},
| ^~~
nfs4acleditor.h:132:22: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
132 | {NFS4_ACE_ADD_FILE, "add file", "w"},
| ^~~~~~~~~~
nfs4acleditor.h:132:34: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
132 | {NFS4_ACE_ADD_FILE, "add file", "w"},
| ^~~
nfs4acleditor.h:134:30: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
134 | {NFS4_ACE_ADD_SUBDIRECTORY, "add subdirectory", "a"},
| ^~~~~~~~~~~~~~~~~~
nfs4acleditor.h:134:50: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
134 | {NFS4_ACE_ADD_SUBDIRECTORY, "add subdirectory", "a"},
| ^~~
nfs4acleditor.h:135:21: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
135 | {NFS4_ACE_EXECUTE, "execute", "x"},
| ^~~~~~~~~
nfs4acleditor.h:135:32: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
135 | {NFS4_ACE_EXECUTE, "execute", "x"},
| ^~~
nfs4acleditor.h:136:26: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
136 | {NFS4_ACE_DELETE_CHILD, "delete child", "D"},
| ^~~~~~~~~~~~~~
nfs4acleditor.h:136:42: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
136 | {NFS4_ACE_DELETE_CHILD, "delete child", "D"},
| ^~~
nfs4acleditor.h:137:20: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
137 | {NFS4_ACE_DELETE, "delete", "d" },
| ^~~~~~~~
nfs4acleditor.h:137:30: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
137 | {NFS4_ACE_DELETE, "delete", "d" },
| ^~~
nfs4acleditor.h:138:29: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
138 | {NFS4_ACE_READ_ATTRIBUTES, "read attrs", "t"},
| ^~~~~~~~~~~~
nfs4acleditor.h:138:43: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
138 | {NFS4_ACE_READ_ATTRIBUTES, "read attrs", "t"},
| ^~~
nfs4acleditor.h:139:30: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
139 | {NFS4_ACE_WRITE_ATTRIBUTES, "write attrs", "T"},
| ^~~~~~~~~~~~~
nfs4acleditor.h:139:45: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
139 | {NFS4_ACE_WRITE_ATTRIBUTES, "write attrs", "T"},
| ^~~
nfs4acleditor.h:140:30: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
140 | {NFS4_ACE_READ_NAMED_ATTRS, "read named attrs", "n"},
| ^~~~~~~~~~~~~~~~~~
nfs4acleditor.h:140:50: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
140 | {NFS4_ACE_READ_NAMED_ATTRS, "read named attrs", "n"},
| ^~~
nfs4acleditor.h:141:31: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
141 | {NFS4_ACE_WRITE_NAMED_ATTRS, "write named attrs", "N"},
| ^~~~~~~~~~~~~~~~~~~
nfs4acleditor.h:141:52: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
141 | {NFS4_ACE_WRITE_NAMED_ATTRS, "write named attrs", "N"},
| ^~~
nfs4acleditor.h:142:22: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
142 | {NFS4_ACE_READ_ACL, "read ACL", "c"},
| ^~~~~~~~~~
nfs4acleditor.h:142:34: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
142 | {NFS4_ACE_READ_ACL, "read ACL", "c"},
| ^~~
nfs4acleditor.h:143:23: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
143 | {NFS4_ACE_WRITE_ACL, "write ACL", "C"},
| ^~~~~~~~~~~
nfs4acleditor.h:143:36: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
143 | {NFS4_ACE_WRITE_ACL, "write ACL", "C"},
| ^~~
nfs4acleditor.h:144:25: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
144 | {NFS4_ACE_WRITE_OWNER, "write owner", "o"},
| ^~~~~~~~~~~~~
nfs4acleditor.h:144:40: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
144 | {NFS4_ACE_WRITE_OWNER, "write owner", "o"},
| ^~~
nfs4acleditor.h:145:25: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
145 | {NFS4_ACE_SYNCHRONIZE, "synchronize", "y"},
| ^~~~~~~~~~~~~
nfs4acleditor.h:145:40: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
145 | {NFS4_ACE_SYNCHRONIZE, "synchronize", "y"},
| ^~~
nfs4acleditor.h:154:26: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
154 | {NFS4_ACE_GENERIC_READ, "\"read\"", ""},
| ^~~~~~~~~~
nfs4acleditor.h:154:38: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
154 | {NFS4_ACE_GENERIC_READ, "\"read\"", ""},
| ^~
nfs4acleditor.h:155:27: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
155 | {NFS4_ACE_GENERIC_WRITE, "\"write\"", ""},
| ^~~~~~~~~~~
nfs4acleditor.h:155:40: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
155 | {NFS4_ACE_GENERIC_WRITE, "\"write\"", ""},
| ^~
nfs4acleditor.h:156:29: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
156 | {NFS4_ACE_GENERIC_EXECUTE, "\"exec\"", ""},
| ^~~~~~~~~~
nfs4acleditor.h:156:41: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
156 | {NFS4_ACE_GENERIC_EXECUTE, "\"exec\"", ""},
| ^~
nfs4acleditor.h:157:22: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
157 | {NFS4_ACE_MASK_ALL, "all", ""},
| ^~~~~
nfs4acleditor.h:157:29: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
157 | {NFS4_ACE_MASK_ALL, "all", ""},
| ^~
nfs4acleditor.h:161:37: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
161 | {NFS4_ACE_ACCESS_ALLOWED_ACE_TYPE, "ALLOW", "A"},
| ^~~~~~~
nfs4acleditor.h:161:46: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
161 | {NFS4_ACE_ACCESS_ALLOWED_ACE_TYPE, "ALLOW", "A"},
| ^~~
nfs4acleditor.h:162:36: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
162 | {NFS4_ACE_ACCESS_DENIED_ACE_TYPE, "DENY", "D"},
| ^~~~~~
nfs4acleditor.h:162:44: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
162 | {NFS4_ACE_ACCESS_DENIED_ACE_TYPE, "DENY", "D"},
| ^~~
nfs4acleditor.h:163:35: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
163 | {NFS4_ACE_SYSTEM_AUDIT_ACE_TYPE, "AUDIT", "U"},
| ^~~~~~~
nfs4acleditor.h:163:44: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
163 | {NFS4_ACE_SYSTEM_AUDIT_ACE_TYPE, "AUDIT", "U"},
| ^~~
nfs4acleditor.h:164:35: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
164 | {NFS4_ACE_SYSTEM_ALARM_ACE_TYPE, "ALARM", "L"},
| ^~~~~~~
nfs4acleditor.h:164:44: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
164 | {NFS4_ACE_SYSTEM_ALARM_ACE_TYPE, "ALARM", "L"},
| ^~~
nfs4acleditor.h:168:30: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
168 | {NFS4_ACE_FILE_INHERIT_ACE, "file-inherit", "f"},
| ^~~~~~~~~~~~~~
nfs4acleditor.h:168:46: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
168 | {NFS4_ACE_FILE_INHERIT_ACE, "file-inherit", "f"},
| ^~~
nfs4acleditor.h:169:35: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
169 | {NFS4_ACE_DIRECTORY_INHERIT_ACE, "directory-inherit", "d"},
| ^~~~~~~~~~~~~~~~~~~
nfs4acleditor.h:169:56: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
169 | {NFS4_ACE_DIRECTORY_INHERIT_ACE, "directory-inherit", "d"},
| ^~~
nfs4acleditor.h:170:38: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
170 | {NFS4_ACE_NO_PROPAGATE_INHERIT_ACE, "no-propagate-inherit", "n"},
| ^~~~~~~~~~~~~~~~~~~~~~
nfs4acleditor.h:170:62: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
170 | {NFS4_ACE_NO_PROPAGATE_INHERIT_ACE, "no-propagate-inherit", "n"},
| ^~~
nfs4acleditor.h:171:30: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
171 | {NFS4_ACE_INHERIT_ONLY_ACE, "inherit-only", "i"},
| ^~~~~~~~~~~~~~
nfs4acleditor.h:171:46: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
171 | {NFS4_ACE_INHERIT_ONLY_ACE, "inherit-only", "i"},
| ^~~
nfs4acleditor.h:172:40: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
172 | {NFS4_ACE_SUCCESSFUL_ACCESS_ACE_FLAG, "successful access", "S"},
| ^~~~~~~~~~~~~~~~~~~
nfs4acleditor.h:172:61: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
172 | {NFS4_ACE_SUCCESSFUL_ACCESS_ACE_FLAG, "successful access", "S"},
| ^~~
nfs4acleditor.h:173:36: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
173 | {NFS4_ACE_FAILED_ACCESS_ACE_FLAG, "failed access", "F"},
| ^~~~~~~~~~~~~~~
nfs4acleditor.h:173:53: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
173 | {NFS4_ACE_FAILED_ACCESS_ACE_FLAG, "failed access", "F"},
| ^~~
nfs4acleditor.h:174:30: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
174 | {NFS4_ACE_IDENTIFIER_GROUP, "identifier group", "g"},
| ^~~~~~~~~~~~~~~~~~
nfs4acleditor.h:174:50: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
174 | {NFS4_ACE_IDENTIFIER_GROUP, "identifier group", "g"},
| ^~~
nfs4acleditor.cpp: In constructor NFS4_ACL_Editor::NFS4_ACL_Editor(QWidget*, char*) :
nfs4acleditor.cpp:82:26: error: class QHeaderView has no member named setResizeMode ; did you mean ResizeMode ?
82 | tw->horizontalHeader()->setResizeMode(1, QHeaderView::Stretch);
| ^~~~~~~~~~~~~
| ResizeMode
nfs4acleditor.cpp:83:26: error: class QHeaderView has no member named setMovable ; did you mean setLocale ?
83 | tw->horizontalHeader()->setMovable(true);
| ^~~~~~~~~~
| setLocale
nfs4acleditor.cpp:84:24: error: class QHeaderView has no member named setResizeMode ; did you mean ResizeMode ?
84 | tw->verticalHeader()->setResizeMode(QHeaderView::Custom);
| ^~~~~~~~~~~~~
| ResizeMode
nfs4acleditor.cpp: In member function void NFS4_ACL_Editor::aceSelected(int, int, int, int) :
nfs4acleditor.cpp:199:48: warning: unused parameter column [-Wunused-parameter]
199 | void NFS4_ACL_Editor::aceSelected(int row, int column, int prevrow, int prevcolumn)
| ~~~~^~~~~~
nfs4acleditor.cpp:199:73: warning: unused parameter prevcolumn [-Wunused-parameter]
199 | void NFS4_ACL_Editor::aceSelected(int row, int column, int prevrow, int prevcolumn)
| ~~~~^~~~~~~~~~
nfs4acleditor.cpp: In member function void NFS4_ACL_Editor::newACE() :
nfs4acleditor.cpp:328:101: warning: ISO C++ forbids converting a string constant to char* [-Wwrite-strings]
328 | ace = nfs4_new_ace(nacl->is_directory, NFS4_ACE_ACCESS_ALLOWED_ACE_TYPE, 0, 0, NFS4_ACL_WHO_NAMED, " ");
| ^~~
make: *** [Makefile:416: nfs4acleditor.o] Error 1
Changed 3 lines in nfs4acleditor.cpp to tw->horizontalHeader()->setSectionResizeMode(1, QHeaderView::Stretch); tw->horizontalHeader()->setSectionsMovable(true); tw->verticalHeader()->setSectionResizeMode(QHeaderView::Custom); and now compiles with no errors. Ready for testing! |