Bug 2228189 (golang-github-phpdave11-gofpdi)

Summary: Review Request: golang-github-phpdave11-gofpdi - Go Free PDF Document Importer
Product: [Fedora] Fedora Reporter: Robert-André Mauchin 🐧 <eclipseo>
Component: Package ReviewAssignee: Pavel Solovev <daron439>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: daron439, package-review
Target Milestone: ---Flags: daron439: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-11-09 08:16:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Robert-André Mauchin 🐧 2023-08-01 17:12:08 UTC
Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-phpdave11-gofpdi.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-phpdave11-gofpdi-1.0.13-1.20230731git1f10f98.fc38.src.rpm

Description:
Go Free PDF Document Importer.

Fedora Account System Username: eclipseo

Comment 2 Pavel Solovev 2023-08-02 07:36:05 UTC
The package is in fedora https://src.fedoraproject.org/rpms/golang-github-phpdave11-gofpdi. Can be unretired without review.

Comment 3 Robert-André Mauchin 🐧 2023-08-02 20:35:46 UTC
(In reply to Pavel Solovev from comment #2)
> The package is in fedora
> https://src.fedoraproject.org/rpms/golang-github-phpdave11-gofpdi. Can be
> unretired without review.

No it can't, it ha been orphaned for more than 6 weeks, it needs a new review.

Comment 4 Pavel Solovev 2023-08-02 21:35:58 UTC
https://docs.fedoraproject.org/en-US/package-maintainers/Package_Retirement_Process/

> Retired Fedora packages (rawhide branch retired) require a re-review if they are retired for more than eight weeks or if there is no previous review of the package.

It was retired a week ago, but I couldn't find the previous review of the package...


Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The specfile is sane.
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved!

Comment 5 Package Review 2024-11-09 08:16:42 UTC
Package imported and now orphaned.