Bug 2228788
| Summary: | Review Request: python-comm - Jupyter Python Comm implementation, for usage in ipykernel, xeus-python etc. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lumír Balhar <lbalhar> |
| Component: | Package Review | Assignee: | Maxwell G <maxwell> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | maxwell, mhroncok, package-review |
| Target Milestone: | --- | Flags: | maxwell:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://github.com/ipython/comm | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-08-11 07:13:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2144566, 2228034 | ||
|
Description
Lumír Balhar
2023-08-03 09:33:40 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6237104 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2228788-python-comm/fedora-rawhide-x86_64/06237104-python-comm/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The license text is included and marked with %license.
NOTE: Handled by %pyproject_save_files
- [x] The package builds successfully in mock.
- [x] The package is installable (checked by fedora-review).
- [!] There are no relevant rpmlint errors.
python-comm.src: W: summary-ended-with-dot Jupyter Python Comm implementation, for usage in ipykernel, xeus-python etc.
python3-comm.noarch: W: summary-ended-with-dot Jupyter Python Comm implementation, for usage in ipykernel, xeus-python etc.
- [x] The package runs tests in %check.
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The packager considers avoiding confusing `%foo_name` macros. (Not a blocker)
- [x] Libraries: The package name has a `python3-` prefix and uses the canonical project name
- [-] Applications: The package follows the general Naming Guidelines for applications
- [x] The pyproject macros are used.
- [x] There are no bundled libraries.
- [!] The package complies with the Python and general Packaging Guidelines.
The package does not abide by the SourceURL guidelines.
Source: %{url}/archive/v%{version}.tar.gz
should be
Source: %{url}/archive/v%{version}/comm-%{version}.tar.gz
- [!] There are no relevant rpmlint errors. python-comm.src: W: summary-ended-with-dot Jupyter Python Comm implementation, for usage in ipykernel, xeus-python etc. python3-comm.noarch: W: summary-ended-with-dot Jupyter Python Comm implementation, for usage in ipykernel, xeus-python etc. I understand this guideline as: Don't make it a sentence. However, "etc." has the dot in it naturally, I would not consider this a problem here. Indeed, that warning is a false positive. I did not read the Summary closely enough... Thank you for the review. Source URL fixed. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The license text is included and marked with %license. - [x] The package builds successfully in mock. - [x] The package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The packager considers avoiding confusing `%foo_name` macros. (Not a blocker) - [x] Libraries: The package name has a `python3-` prefix and uses the canonical project name - [-] Applications: The package follows the general Naming Guidelines for applications - [x] The pyproject macros are used. - [x] There are no bundled libraries. - [x] The package complies with the Python and general Packaging Guidelines. Package approved! On import, don't forget to add the package to release-monitoring.org. You can give @python-packagers-sig `commit` if you wish` Thanks! The Pagure repository was created at https://src.fedoraproject.org/rpms/python-comm FEDORA-2023-76dbdf058b has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-76dbdf058b FEDORA-2023-76dbdf058b has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-6cb733624a has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-6cb733624a FEDORA-2023-6cb733624a has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |