Bug 2229173

Summary:	[16.2] OpenStackConfigGenerator fails to clone from Azure DevOps with empty git-upload-pack given
Product:	Red Hat OpenStack	Reporter:	Martin Schuppert <mschuppe>
Component:	osp-director-operator-container	Assignee:	OSP Team <rhos-maint>
Status:	CLOSED ERRATA	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	16.2 (Train)	CC:	jschluet, pkomarov
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	osp-director-operator-container-1.3.0-8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	2229168	Environment:
Last Closed:	2023-08-22 00:09:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2229168
Bug Blocks:

Description Martin Schuppert 2023-08-04 14:28:39 UTC

+++ This bug was initially created as a clone of Bug #2229168 +++

Description of problem:
when using Azure DevOps as git server after successful create of the playbooks they fail to be pushed to the git repo with 

2023-08-04T13:17:36.345Z        INFO    controllers.OpenStackConfigGenerator    Get "http://heat-default.openstack.svc:8004/v1/admin/stacks/overcloud": dial tcp: lookup heat-default.openstack.svc: no such host   {
"ObjectType": "*v1beta1.OpenStackConfigGenerator", "ObjectNamespace": "openstack", "ObjectName": "default"}                                                                                                          
2023-08-04T13:17:36.345Z        ERROR   Reconciler error        {"controller": "openstackconfiggenerator", "controllerGroup": "osp-director.openstack.org", "controllerKind": "OpenStackConfigGenerator", "OpenStackC
onfigGenerator": {"name":"default","namespace":"openstack"}, "namespace": "openstack", "name": "default", "reconcileID": "51a3144c-b692-4ff4-853d-2e5a33d7a27a", "error": "empty git-upload-pack given"}  
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler                                                                                                                                
        /go/pkg/mod/sigs.k8s.io/controller-runtime.1/pkg/internal/controller/controller.go:326                                                                                                                 
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem                                                                                                                             
        /go/pkg/mod/sigs.k8s.io/controller-runtime.1/pkg/internal/controller/controller.go:273                                                                                                                 
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2                                                                                                                                   
        /go/pkg/mod/sigs.k8s.io/controller-runtime.1/pkg/internal/controller/controller.go:234

Version-Release number of selected component (if applicable):
OSPdO 16.2

How reproducible:


Steps to Reproduce:
1. create new Azure DevOps org
2. create repo
3. add SSH key
4. configure OSPdO to use this
5. create OpenStackConfigGenerator

Actual results:
fail to push playbooks to git repo

Expected results:
succeed

Additional info:
https://github.com/go-git/go-git/pull/613

Comment 7 pkomarov 2023-08-15 08:56:47 UTC

Verifid by https://bugzilla.redhat.com/show_bug.cgi?id=2229173#c5 and https://bugzilla.redhat.com/show_bug.cgi?id=2229173#c6

Comment 14 errata-xmlrpc 2023-08-22 00:09:39 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Release of containers for OSP 16.2.z (Train) director Operator), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:4694