Bug 2229629

Summary:	[Machines] The "Uptime" should be "over xx hour" instead of "about xx hour"
Product:	Red Hat Enterprise Linux 8	Reporter:	YunmingYang <yunyang>
Component:	cockpit-appstream	Assignee:	Simon Kobyda <skobyda>
Status:	CLOSED WONTFIX	QA Contact:	YunmingYang <yunyang>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	8.9	CC:	jscotka, kkoukiou, mpitt, qzhang, wshi, xchen, ymao
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-08-07 06:57:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description YunmingYang 2023-08-07 06:34:22 UTC

Description of problem:
Create a running VM, then change the time in the VM log to 1 hour and 1 minute less than the current time. Then click the "Shut down" button to check the confirmation dialog, the "Uptime" is "about 1 hour"

Version-Release number of selected components (if applicable):
cockpit-machines-297-1.el8.noarch
cockpit-297-1.el8.x86_64
libvirt-dbus-1.3.0-2.module+el8.9.0+18724+20190c23.x86_64

How reproducible:
100%

Steps to Reproduce:
1 Create a running VM
2 Modify the time in the VM log to 1 hour and 1 minute less than the current time
3 Click the "Shut down" button, check the confirmation dialog

Actual results:
1 After step 3, the "Uptime" is "about 1 hour"

Expected results:
1 After step 3, the "Uptime" should be "over 1 hour"

Additional info:

Comment 1 Martin Pitt 2023-08-07 06:54:14 UTC

Hmm, this is what https://date-fns.org/ does, which is pretty much *the* JS library for localizing/humanizing times. TBH this sounds like a "wontfix" to me, as long as it's not grossly wrong.

Comment 2 YunmingYang 2023-08-07 06:56:27 UTC

Thanks, then feel free to close this issue with "wontfix".

Comment 3 Martin Pitt 2023-08-07 06:57:40 UTC

Ack, thanks!