Bug 222964
| Summary: | Review Request: dayplanner - A simple time management program. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Kovats <johnny.d> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mtasaka |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-04-13 10:00:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Jan Kovats
2007-01-17 05:09:39 UTC
(Please block both FE-NEW and FE-NEEDSPONSOR) (In reply to comment #1) > (Please block both FE-NEW and FE-NEEDSPONSOR) Thanks for your help :) Well, I must say that your spec file contains not a few issues to fix. Please check: http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines From just I looked at your spec file: A. Description entry * Release - please add %{?_dist} entry unless you have a reason not to do so. http://fedoraproject.org/wiki/Packaging/DistTag * Source0 - please specify URL. * BuildRequires - please remove redundant BuildRequires. "perl" is in minimum buildroot and required automatically by "perl-gettext", so this is not needed. * %include_holidayparser - Currently I don't understand this well. If this package can use CPAN Date::HolidayParser module, you should not include perl module in this package and should submit CPAN module package instead. http://ftp.cpan.jp/authors/id/Z/ZE/ZERODOGG/ B. %build stage * Adding %build entry is preferred even if it is completely empty. C. %install stage * "install -mXXX" - Use "install -p -mXXX" to keep timestamps. * Executable scripts/binaries install directory - By the way why do you install "dayplanner dayplanner-daemon dayplanner-notifier" once into %{_datadir}/%{name} instead of directly installing into %{_bindir}? * Desktop file install - "install -m644 ./doc/%{name}.desktop" Please use desktop-file-install ("Desktop files" entry of http://fedoraproject.org/wiki/Packaging/Guidelines) D. scriptlets ------------------------------------------------------------- %post %{update_menus} %postun %{clean_menus} ------------------------------------------------------------- These macros are not defined. Check: http://fedoraproject.org/wiki/Extras/RPMMacros E. file entry * macros ------------------------------------------------------------- %{_iconsdir}/dayplanner*.png %{_miconsdir}/dayplanner*.png %{_liconsdir}/dayplanner*.png %{_menudir}/%{name} -------------------------------------------------------------- These macros are also undefined. * subpackage - Would you explain why you want to split dayplanner-commander into different subpackage? ping? (In reply to comment #4) > ping? Pong! Ack Sorry. I'm very thankfull for all your notes. I looked at Guidlines and tried to do it right the first time but i fergot a few things as you pointed out. I didn't answer cause i was busy doing the changes. I didn't have that much time the past few days. But i'm soon going to update with and updated spec file and the holiday parser as a seperate rpm. Again thanks for taking the time and effort to look through my crude spec. again? Again ping? I will close this bug in a week unless any response is made on this bug. Closing for now. If you want to try this software, feel free to reopen this bug. |