Bug 2229895

Verify passed with ostree-2022.2-8.el8.x86_64, thanks Joseph and Colin for the guidance.

Steps:

Create cluster using OCP 4.12.28 on gcp: 

- reproduce with unfixed ostree: exec steps according to the video of Colin (see https://issues.redhat.com/browse/OCPBUGS-15917?focusedId=22747033&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-22747033), and run `ip link set ens4 down; sleep 5; reboot`, check the node is down, when node is back after waiting about 30min, check that could not get kernel parameter `test=1`

- manually upgrade ostree on the node to ostree-2022.2-8.el8.x86_64 and reboot, exec same steps, check we have kernel parameter `test=1` after the node is back, service still failed as expected.

[root@ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn ~]# rpm -q ostree
ostree-2022.2-8.el8.x86_64

[root@ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn ~]# cat /proc/cmdline 
... test=1

[root@ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn ~]# journalctl -b -1 -u ostree-finalize-staged.service
-- Logs begin at Tue 2023-08-15 13:41:46 UTC, end at Tue 2023-08-15 15:33:07 UTC. --
Aug 15 14:58:09 ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn systemd[1]: Started OSTree Finalize Staged Deployment.
Aug 15 15:03:00 ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn systemd[1]: Stopping OSTree Finalize Staged Deployment...
Aug 15 15:03:00 ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn ostree[29496]: Finalizing staged deployment
Aug 15 15:03:02 ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn ostree[29496]: Copying /etc changes: 14 modified, 0 removed, 133 added
Aug 15 15:03:02 ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn ostree[29496]: Copying /etc changes: 14 modified, 0 removed, 133 added
Aug 15 15:03:10 ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn ostree[29496]: Timed out waiting for global sync()
Aug 15 15:03:11 ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn ostree[29496]: Bootloader updated; bootconfig swap: yes; bootversion: boot.0.1, deployment count chan>
Aug 15 15:03:11 ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn ostree[29496]: Bootloader updated; bootconfig swap: yes; bootversion: boot.0.1, deployment count chan>
Aug 15 15:08:00 ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn systemd[1]: ostree-finalize-staged.service: Stopping timed out. Terminating.
Aug 15 15:13:01 ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn systemd[1]: ostree-finalize-staged.service: State 'stop-sigterm' timed out. Killing.
Aug 15 15:13:01 ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn systemd[1]: ostree-finalize-staged.service: Killing process 29496 (ostree) with signal SIGKILL.
Aug 15 15:18:01 ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn systemd[1]: ostree-finalize-staged.service: Processes still around after SIGKILL. Ignoring.
Aug 15 15:23:01 ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn systemd[1]: ostree-finalize-staged.service: State 'stop-final-sigterm' timed out. Killing.
Aug 15 15:23:01 ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn systemd[1]: ostree-finalize-staged.service: Killing process 29496 (ostree) with signal SIGKILL.
Aug 15 15:28:01 ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn systemd[1]: ostree-finalize-staged.service: Processes still around after final SIGKILL. Entering fail>
Aug 15 15:28:01 ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn systemd[1]: ostree-finalize-staged.service: Failed with result 'timeout'.
Aug 15 15:28:01 ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn systemd[1]: Stopped OSTree Finalize Staged Deployment.
Aug 15 15:28:01 ci-ln-22pq4y2-72292-9h7tq-worker-a-wd9mn systemd[1]: ostree-finalize-staged.service: Consumed 3.458s CPU time

Change status to verified according to result in Comment 1

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (ostree bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:7063