Bug 2229910

Summary:	Problem with requirement `/usr/lib/ocf/resource.d`
Product:	[Fedora] Fedora	Reporter:	Jaroslav Mracek <jmracek>
Component:	glusterfs	Assignee:	Kaleb KEITHLEY <kkeithle>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	38	CC:	amarts, anoopcs, congxueyang, jonathansteffan, kkeithle, ndevos
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-11.0-5.fc40	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-08-22 17:28:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2180842

Description Jaroslav Mracek 2023-08-08 08:12:32 UTC

Package glusterfs-resource-agents requires: /usr/lib/ocf/resource.d

Why this is a problem:
1. DNF5 stops to download filelists as a default therefore `glusterfs-resource-agents` will be not installable
2. It is against Fedora packaging guidelines to require files outside of `/etc`, `/usr/(s)bin`.


Possible solution:
1. use only file provides from  `/etc`, `/usr/(s)bin` (follow packaging guidelines please) or other provides from package providing required functionality
2. Request explicit provider of `/usr/lib/ocf/resource.d` in package providers of the file `Provides: /usr/lib/ocf/resource.d`. This is a workaround that resolves the issue, but is not according to guidelines.

This issue will appear after DNF5 adoption, because DNF5 does not download filelists by default. The problem will not be in DNF because it is caused by not following packaging guidelines. DNF downloaded always filelists to prevent the issue. There are only few remaining packages that has the issue therefore it is time to improve an efficiency of Fedora distribution.

Reproducible: Always

Reproducible: Always

Comment 1 Jaroslav Mracek 2023-08-08 08:20:34 UTC

May be this could be used as an alternative: https://src.fedoraproject.org/rpms/kata-containers/pull-request/4#request_diff

Comment 2 Kaleb KEITHLEY 2023-08-14 13:41:23 UTC

(In reply to Jaroslav Mracek from comment #1)
> May be this could be used as an alternative:
> https://src.fedoraproject.org/rpms/kata-containers/pull-request/
> 4#request_diff

I don't see how that is applicable.

Nor do I understand (can't parse) the statement "DNF5 stops to download filelists as a default ..."  What does that even mean?

See https://bugzilla.redhat.com/show_bug.cgi?id=1731689, the question raised there was never answered.

Here's an excerpt of the .spec file from https://kojipkgs.fedoraproject.org//packages/resource-agents/4.12.0/3.fc39.1/src/resource-agents-4.12.0-3.fc39.1.src.rpm

...
%if %{with linuxha}
%dir %{_usr}/lib/ocf
%dir %{_usr}/lib/ocf/resource.d
%dir %{_usr}/lib/ocf/lib

%{_usr}/lib/ocf/lib/heartbeat

%{_usr}/lib/ocf/resource.d/heartbeat
%if %{with rgmanager}
%{_usr}/lib/ocf/resource.d/redhat
%endif
...

Comment 3 Kaleb KEITHLEY 2023-08-14 18:02:29 UTC

(In reply to Kaleb KEITHLEY from comment #2)
> 
> Here's an excerpt of the .spec file from
> https://kojipkgs.fedoraproject.org//packages/resource-agents/4.12.0/3.fc39.1/
> src/resource-agents-4.12.0-3.fc39.1.src.rpm
> 
> ...
> %if %{with linuxha}
> %dir %{_usr}/lib/ocf
> %dir %{_usr}/lib/ocf/resource.d
> %dir %{_usr}/lib/ocf/lib
> 
> %{_usr}/lib/ocf/lib/heartbeat
> 
> %{_usr}/lib/ocf/resource.d/heartbeat
> %if %{with rgmanager}
> %{_usr}/lib/ocf/resource.d/redhat
> %endif
> ...

IOW, this is, in many ways, the parent package of the glusterfs-resource-ag, and even it still references %dir %{_usr}/lib/ocf/resource.d in its %files section.

%{_usr}/lib/ocf/resource.d/... is the canonical location where resource agents are installed.

Is there a bz to fix the resource-agents rpm? How is that being fixed? (I don't see any evidence pacemaker and resource-agents are switching to a different location.

Comment 4 Fedora Update System 2023-08-22 17:25:54 UTC

FEDORA-2023-1ee8adf94d has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-1ee8adf94d

Comment 5 Fedora Update System 2023-08-22 17:28:32 UTC

FEDORA-2023-1ee8adf94d has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Red Hat Bugzilla 2023-12-21 04:25:21 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days