Bug 2230085 (golang-github-brunoscheufler-aws-ecs-met)
| Summary: | Review Request: golang-github-brunoscheufler-aws-ecs-metadata - Retrieve AWS ECS Task metadata | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert-André Mauchin 🐧 <eclipseo> | ||||
| Component: | Package Review | Assignee: | Pavel Solovev <daron439> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | daron439, package-review | ||||
| Target Milestone: | --- | Flags: | daron439:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-09-14 00:43:38 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Robert-André Mauchin 🐧
2023-08-08 16:56:42 UTC
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=104543608 New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-brunoscheufler-aws-ecs-metadata.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-brunoscheufler-aws-ecs-metadata-0-0.1.20230903git67e37ae.fc38.src.rpm Created attachment 1986879 [details]
The .spec file difference from Copr build 6258162 to 6368458
Golang Package Review
==============
This package was generated using go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The specfile is sane.
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
Thanks!
Thank you so much Pavel! Thank you for the review, Pavel https://pagure.io/releng/fedora-scm-requests/issue/56085 The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-brunoscheufler-aws-ecs-metadata FEDORA-2023-e3b35e9ca6 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e3b35e9ca6 FEDORA-2023-89259e6c19 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-89259e6c19 FEDORA-2023-825ad2f16f has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-825ad2f16f FEDORA-2023-89259e6c19 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-89259e6c19 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-89259e6c19 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-e3b35e9ca6 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-e3b35e9ca6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e3b35e9ca6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-825ad2f16f has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-825ad2f16f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-825ad2f16f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-825ad2f16f has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-89259e6c19 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-e3b35e9ca6 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |