Bug 2230450

Summary:	Review Request: msv - Multi-Schema Validator Toolkit
Product:	[Fedora] Fedora	Reporter:	Marián Konček <mkoncek>
Component:	Package Review	Assignee:	Mikolaj Izdebski <mizdebsk>
Status:	ASSIGNED ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mizdebsk, package-review
Target Milestone:	---	Flags:	mizdebsk: fedora-review?
Target Release:	---
Hardware:	All
OS:	Linux
URL:	https://xmlark.github.io/msv/
Whiteboard:	Unretirement
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2229980
Bug Blocks:

Description Marián Konček 2023-08-09 13:07:21 UTC

Spec URL: https://fedorapeople.org/~mkoncek/msv/msv.spec
SRPM URL: https://fedorapeople.org/~mkoncek/msv/msv-2022.7-1.fc39.src.rpm
Description:
The Multi Schema Validation toolkit is a Java based toolkit consisting of 8
different submodules. The core module is the Multi-Schema XML Validator (MSV)
for the validation of XML documents against several kinds of XML schemata The
core supports RELAX NG, RELAX Namespace, RELAX Core, TREX, XML DTDs, and a
subset of XML Schema Part 1.

Fedora Account System Username: mkoncek

Note: This package requires a legal package review.

Comment 1 Fedora Review Service 2023-08-09 13:11:37 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6260447
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2230450-msv/fedora-rawhide-x86_64/06260447-msv/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Marián Konček 2023-08-09 13:21:13 UTC

Depends on: https://bugzilla.redhat.com/show_bug.cgi?id=2229980

Comment 3 Marián Konček 2023-08-16 12:39:52 UTC

Communication related to legal side:
https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/thread/Q75WNFHBZ5HHHTPXPGRWO42NDUJJIPHL/

Comment 4 Mikolaj Izdebski 2023-08-16 13:33:39 UTC

generate-tarball.sh script is not included in SRPM.
This is a blocker for proceeding with the review.

Comment 5 Mikolaj Izdebski 2023-08-17 07:54:07 UTC

Licensing review:
Licensing tags should be unified, there is no reason to have separate licenses for source and binary packages.
There should be licensing breakdown comment as licensing is complex.
Sun BSD license should be included in license tags.