Bug 2231205

Summary: Review Request: golang-github-google-28 - Go library for accessing the GitHub v3 API
Product: [Fedora] Fedora Reporter: W. Michael Petullo <mike>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: POST --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description W. Michael Petullo 2023-08-11 02:24:19 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-google-github-28.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-google-28-28.1.1-1.fc38.src.rpm
Description: Go library for accessing the GitHub v3 API
Fedora Account System Username: mikep

COPR repository:
[copr:copr.fedorainfracloud.org:mikep:golang]
name=Copr repo for golang owned by mikep
baseurl=https://download.copr.fedorainfracloud.org/results/mikep/golang/fedora-$releasever-$basearch/
type=rpm-md
skip_if_unavailable=True
gpgcheck=1
gpgkey=https://download.copr.fedorainfracloud.org/results/mikep/golang/pubkey.gpg
repo_gpgcheck=0
enabled=1
enabled_metadata=1

Comment 1 Major Hayden 🤠 2023-08-11 18:09:04 UTC
Were you still working on this one? https://copr.fedorainfracloud.org/coprs/mikep/golang/package/golang-github-google-28/

I didn't see any passing builds in your COPR.

Comment 2 W. Michael Petullo 2023-08-11 18:13:12 UTC
There is a dependency problem, which I hope will bubble out the the Rawhide/F39 switch that just happened. I cannot pull golang-opentelemetry-otel into Rawhide right now even though the package seems maintained and present at dl.fedoraproject.org.

Comment 3 W. Michael Petullo 2023-08-13 14:28:01 UTC
This seems to depend on bug #2225896. On the other hand, 3/4 of the architecture builds in COPR succeeded this morning (https://copr.fedorainfracloud.org/coprs/mikep/golang/build/6270224/), but I am worried it might be a fluke. I will check again tomorrow. I emailed the maintainer of golang-opentelemetry-otel-0.20, and I will follow up on the mailing lists if this does not resolve itself and I do not receive a response.

Comment 4 W. Michael Petullo 2023-08-13 22:07:39 UTC
I think things are back on track. The Copr build succeeds again now: https://copr.fedorainfracloud.org/coprs/mikep/golang/build/6270551/.

Comment 5 Robert-André Mauchin 🐧 2023-08-14 18:09:33 UTC
Yeah sorry about that, I pushed the wrong otel package the other, asked releng to untag it, but then the previous package was not tagged for F40/F39, so otel-0.20 took over. I asked releng to fix it Sunday morning, and it was fixed later that day.


Clean up this every time you use go2rpm:

%global golicenses      LICENSE github/licenses.go github/licenses_test.go
%global godocs          example AUTHORS CONTRIBUTING.md README.md example\\\
                        scrape/README.md
->

%global golicenses      LICENSE
%global godocs          example AUTHORS CONTRIBUTING.md README.md


%license LICENSE github/licenses.go github/licenses_test.go
%doc example AUTHORS CONTRIBUTING.md README.md example scrape/README.md

->

%license LICENSE
%doc example AUTHORS CONTRIBUTING.md README.md




Are you sure you need this package? We have golang-github-google-go-github at version 53 in Fedora:

# Generated by go2rpm 1.9.0
# Needs network
%bcond_with check
%global debug_package %{nil}

# https://github.com/google/go-github
%global goipath         github.com/google/go-github
Version:                53.1.0

%gometa

%global goname golang-github-google-go-github

%global goaltipaths     github.com/google/go-github/v53



What I do in most package is switch the import path so it depends on the Fedora Package:


sed -i 's|github.com/google/go-github/v35|github.com/google/go-github|' $(find . -iname '*.go' -type f)



Usually it works, so unless you need that very specific version, I'd recommend against packaging it.


- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Package approved.

Please:
 - add commit rights to go-sig after requesting the repo
 - add the package to Koschei in the go-sig group on all branches you are building
 - add the package to release-monitoring.org even if it does not release version

Comment 6 Robert-André Mauchin 🐧 2023-08-14 18:18:20 UTC
Also your SPEC name is incorrect.

So I would recommend using a goname to fix the name

%global goname golang-github-google-go-github-28

Otherwise rename the SPEC to follow the computed goname

Comment 7 Fedora Admin user for bugzilla script actions 2023-08-14 18:25:49 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-google-28