Bug 2231612
| Summary: | Review Request: rust-glycin-utils - Sandboxed image rendering | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kalev Lember <klember> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/glycin-utils | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-08-21 17:15:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2233278 | ||
|
Description
Kalev Lember
2023-08-12 12:32:33 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6270616 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2231612-rust-glycin-utils/fedora-rawhide-x86_64/06270616-rust-glycin-utils/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Please report the issue with the missing license file upstream. Adding a symlink LICENSE -> ../LICENSE in the crate directories should be enough to have "cargo publish" pick them up. Thanks! I filed https://gitlab.gnome.org/sophie-h/glycin/-/merge_requests/9 for that. Thank you, package looks good. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass (there are no tests) ! latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora ~ license file is included with %license in %files (manually included from upstream) - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === Note that version 0.1.0-beta.3 was released a few days ago, please update the package soon after or before importing. If you have a few minutes, it would be great if you could review one of my pending packages in return. Thanks a lot, Fabio! I'll definitely review some of your packages (but perhaps tomorrow). The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-glycin-utils Package imported and build under way. It turns out I already had it updated locally to 0.1.0-beta.3 so it was just the matter of pushing it to the new repo :) FEDORA-2023-565277b482 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-565277b482 FEDORA-2023-f46c3cfce5 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f46c3cfce5 FEDORA-2023-565277b482 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-f46c3cfce5 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |