Bug 2231654

Summary: Review Request: rust-gweather-sys - FFI bindings for libgweather
Product: [Fedora] Fedora Reporter: Kalev Lember <klember>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/gweather-sys
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-08-21 17:06:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2231655    

Description Kalev Lember 2023-08-12 21:54:40 UTC
Spec URL: https://kalev.fedorapeople.org/rust-gweather-sys.spec
SRPM URL: https://kalev.fedorapeople.org/rust-gweather-sys-4.3.0-1.fc40.src.rpm
Description: FFI bindings for libgweather.
Fedora Account System Username: kalev

Comment 1 Fedora Review Service 2023-08-13 23:36:06 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6270621
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2231654-rust-gweather-sys/fedora-rawhide-x86_64/06270621-rust-gweather-sys/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-08-21 15:58:21 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
~ license file is included with %license in %files (included manually)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Please file an upstream issue / PR / MR to include the license file in published crates.

If you have the time, I would appreciate if you could review one of my pending packages in return.

Comment 3 Fedora Admin user for bugzilla script actions 2023-08-21 16:55:04 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gweather-sys

Comment 4 Kalev Lember 2023-08-21 17:04:26 UTC
Thanks! I'll do a round of package reviews tomorrow.

PR for the license files: https://gitlab.gnome.org/World/Rust/libgweather-rs/-/merge_requests/3

Comment 5 Fedora Update System 2023-08-21 17:05:20 UTC
FEDORA-2023-7cd15821f4 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-7cd15821f4

Comment 6 Fedora Update System 2023-08-21 17:06:37 UTC
FEDORA-2023-7cd15821f4 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2023-08-21 17:09:06 UTC
FEDORA-2023-6421eef34a has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-6421eef34a

Comment 8 Fedora Update System 2023-08-21 17:09:37 UTC
FEDORA-2023-6421eef34a has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.