Bug 2231710

Summary:	Review Request: magpie - Window manager for Budgie Desktop
Product:	[Fedora] Fedora	Reporter:	Joshua Strobl <joshua>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	POST ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	https://github.com/BuddiesOfBudgie/magpie
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Joshua Strobl 2023-08-13 13:32:31 UTC

Spec URL: https://gist.githubusercontent.com/JoshStrobl/b90e0e4464e6b943809818fd2f9fb287/raw/ffbc3f3a6c83fb5f1192d83f39394beafa86b313/magpie.spec
SRPM URL: https://joshuastrobl.com/magpie-0.9.2-1.fc40.src.rpm
Description: magpie is the window manager for Budgie Desktop 10.8 and later. Magpie v0.x is a soft-fork of Mutter 43.x, with 1.0 and above planned to be wlroots-based. You can learn more at https://github.com/BuddiesOfBudgie/magpie and https://buddiesofbudgie.org/blog/wayland

Important note: This was built locally using mockbuild against rawhide and f38, including builds of mutter with mutter-common. These patches have been submitted at https://src.fedoraproject.org/rpms/mutter/pull-requests and require landing before this can be merged in.

Fedora Account System Username: joshstrobl

Comment 1 Fedora Review Service 2023-08-14 00:01:07 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6270626
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2231710-magpie/fedora-rawhide-x86_64/06270626-magpie/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2023-08-14 00:10:51 UTC

Review notes:

* Package spec complies with Fedora Packaging Guidelines (forks from mutter)
* Package builds (and installs with modified mutter package)
* No serious rpmlint issues

Things to fix on import:

* License tag needs to be converted to SPDX: "GPL-2.0-or-later"
* Source0 can be simplified by referencing URL via "%{url}", thus: "%{url}/releases/download/v%{version}/%{name}-%{version}.tar.xz"
* "%autosetup -S git -n %{name}-%{version}" specifies default "-n %{name}-%{version}" and that part can be dropped
* "%{_libdir}/lib*.so.*" in file list needs to be handled with sonames specified (and optionally macroized)

Otherwise...

PACKAGE APPROVED.

Comment 3 Joshua Strobl 2023-08-14 17:03:30 UTC

I have updated the spec and srpm to address the all items raised by Neal.

Spec is at https://gist.githubusercontent.com/JoshStrobl/b90e0e4464e6b943809818fd2f9fb287/raw/a604fda8cdadf2a618f18ac2bd173e55d5e5c7ea/magpie.spec

SRPM is at same URL as OP: https://joshuastrobl.com/magpie-0.9.2-1.fc40.src.rpm