Bug 2231910
| Summary: | Review Request: rust-lcms2-sys - Bindings for liblcms2 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, klember, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/lcms2-sys | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-08-21 19:03:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2233226 | ||
|
Description
Davide Cavalca
2023-08-14 15:30:33 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=104834904 rust2rpm.conf used for this: [DEFAULT] buildrequires = lcms2-devel lib.requires = lcms2-devel Copr build: https://copr.fedorainfracloud.org/coprs/build/6275480 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2231910-rust-lcms2-sys/fedora-rawhide-x86_64/06275480-rust-lcms2-sys/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === Two comments that don't block the review: 1. It would be great if you could figure out a way to deal with the license file (possibly with upstream) that won't involve patching this in manually. 2. You could drop the "cc" optional build-dependency, it's only used by the static linking features that are removed. (Looks like the "parallel" feature would need to be removed for 2. as well, but it seems this is only for parallel compilation of the C code?) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-lcms2-sys *** Bug 2233219 has been marked as a duplicate of this bug. *** I went ahead and imported the package (with Davide's agreement) as it's blocking rust-lcms2 and the rest of loupe packaging. FEDORA-2023-4a2c527575 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4a2c527575 FEDORA-2023-51bbd40d5e has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-51bbd40d5e FEDORA-2023-4a2c527575 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-51bbd40d5e has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |