Bug 2231938

Summary: Review Request: golang-modernc-golex - A lex/flex like (not fully POSIX lex compatible) utility
Product: [Fedora] Fedora Reporter: W. Michael Petullo <mike>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-08-20 20:00:13 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2231936, 2231937    
Bug Blocks:    

Description W. Michael Petullo 2023-08-14 17:53:15 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-golex.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-golex-1.0.5-1.fc38.src.rpm
Description: A lex/flex like (not fully POSIX lex compatible) utility
Fedora Account System Username: mikep

Comment 1 Robert-André Mauchin 🐧 2023-08-20 17:25:12 UTC
 - Don't glob the entire binary directory:

%{_bindir}/golex

- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Package approved.

Please:
 - add commit rights to go-sig after requesting the repo
 - add the package to Koschei in the go-sig group on all branches you are building
 - add the package to release-monitoring.org even if it does not release version