Bug 2232626

Summary: Review Request: rust-yansi-term - Library for ANSI terminal colours and styles (bold, underline)
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: Kalev Lember <klember>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: klember, package-review
Target Milestone: ---Flags: klember: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/yansi-term
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-08-22 20:48:11 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2232627    

Description Fabio Valentini 2023-08-17 15:54:39 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-yansi-term.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-yansi-term-0.1.2-1.fc38.src.rpm

Description:
Library for ANSI terminal colours and styles (bold, underline).

Fedora Account System Username: decathorpe

Comment 1 Fedora Review Service 2023-08-17 16:06:13 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6313493
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2232626-rust-yansi-term/fedora-rawhide-x86_64/06313493-rust-yansi-term/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Kalev Lember 2023-08-22 19:48:48 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
~ license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 3 Fabio Valentini 2023-08-22 20:24:59 UTC
Thanks for the review!

Comment 4 Fedora Admin user for bugzilla script actions 2023-08-22 20:26:50 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-yansi-term

Comment 5 Fabio Valentini 2023-08-22 20:48:11 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-d7e7fbfd91