Bug 2232627

Summary: Review Request: rust-annotate-snippets - Library for building code annotations
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: Kalev Lember <klember>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: klember, package-review
Target Milestone: ---Flags: klember: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/annotate-snippets
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-08-24 12:13:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2232626    
Bug Blocks: 2167834    

Description Fabio Valentini 2023-08-17 15:54:51 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-annotate-snippets.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-annotate-snippets-0.9.1-1.fc38.src.rpm

Description:
Library for building code annotations.

Fedora Account System Username: decathorpe

Comment 1 Fedora Review Service 2023-08-17 15:59:47 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6313494
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2232627-rust-annotate-snippets/fedora-rawhide-x86_64/06313494-rust-annotate-snippets/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Kalev Lember 2023-08-23 09:58:47 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0 OR MIT) and is acceptable for Fedora
~ license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 3 Fabio Valentini 2023-08-24 11:34:24 UTC
Thanks for the review!

Comment 4 Fedora Admin user for bugzilla script actions 2023-08-24 11:34:44 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-annotate-snippets

Comment 5 Fabio Valentini 2023-08-24 12:13:27 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-6d25381b1b