Bug 2232861

Summary:	Review Request: jsemver - A Java implementation of the Semantic Versioning Specification
Product:	[Fedora] Fedora	Reporter:	W. Michael Petullo <mike>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	NEW ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, tim
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2256349

Description W. Michael Petullo 2023-08-19 16:54:27 UTC

Spec URL: https://www.flyn.org/SRPMS/jsemver.spec
SRPM URL: https://www.flyn.org/SRPMS/jsemver-0.9.0-16.fc38.src.rpm
Description: A Java implementation of the Semantic Versioning Specification
Fedora Account System Username: mikep

This package was retired, and I would like to take ownership of it. The only changes I made were to build against the newer Java ABI and drop the maven-javadoc-plugin dependency.

COPR repository:
[copr:copr.fedorainfracloud.org:mikep:lulzbot]
name=Copr repo for lulzbot owned by mikep
baseurl=https://download.copr.fedorainfracloud.org/results/mikep/lulzbot/fedora-$releasever-$basearch/
type=rpm-md
skip_if_unavailable=True
gpgcheck=1
gpgkey=https://download.copr.fedorainfracloud.org/results/mikep/lulzbot/pubkey.gpg
repo_gpgcheck=0
enabled=1
enabled_metadata=1

Comment 1 W. Michael Petullo 2023-08-20 17:05:45 UTC

Spec URL: https://www.flyn.org/SRPMS/jsemver.spec
SRPM URL: https://www.flyn.org/SRPMS/jsemver-0.9.0-1.fc38.src.rpm

- Use %autorelease/%autochangelog
- Use SPDX

Comment 2 Tim Semeijn 2023-10-17 22:34:21 UTC

This is an unofficial review as I am not in the packager group yet.

> Package does not contain duplicates in %files.
> Note: warning: File listed twice: /usr/share/java/jsemver
> See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_duplicate_files

This issue seems a false positive as /usr/share/java/jsemver and /usr/share/maven-poms/jsemver both are folders with the same name but contain different files. This can be ignored.

> License file ADDITIONAL_LICENSE_INFO is not marked as %license
> See: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

File seems to mention additional licensing requirements regarding an exception to the GPLv2 (GNU Classpath Exception). Please verify how this affects licensing and if acceptable to use mark it as %license under %files.

Comment 3 Package Review 2025-01-01 00:45:26 UTC

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.