Bug 2233023

+++ This bug was initially created as a clone of Bug #2150752 +++

Description of problem (please be detailed as possible and provide log
snippets):

When storageclass or PV encryption is enabled on a cluster post deployment, the ocs_advanced_feature_usage_metric does not update it's value to 1. It does not detect the use of PV encryption, unless it is enabled during deployment.


The following logs were observed in the ocs-metrics-exporter pod:

W1205 08:27:51.092918       1 reflector.go:324] /remote-source/app/metrics/internal/collectors/cluster-advance-feature-use.go:166: failed to list *v1.StorageClass: forbidden: User "system:serviceaccount:openshift-storage:ocs-metrics-exporter" cannot get path "/storageclasses"
E1205 08:27:51.092960       1 reflector.go:138] /remote-source/app/metrics/internal/collectors/cluster-advance-feature-use.go:166: Failed to watch *v1.StorageClass: failed to list *v1.StorageClass: forbidden: User "system:serviceaccount:openshift-storage:ocs-metrics-exporter" cannot get path "/storageclasses"


Version of all relevant components (if applicable):
---------------------------------------------------
OCP: 4.12.0-0.nightly-2022-12-04-160656
ODF: odf-operator.v4.12.0-122.stable


Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?
No


Is there any workaround available to the best of your knowledge?
N/A


Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?
2

Can this issue reproducible?
Yes

Can this issue reproduce from the UI?
Yes

If this is a regression, please provide more details to justify this:
No

Steps to Reproduce:
-------------------
1. Deploy an ODF 4.12 cluster without enabling encryption during deployment
2. After deployment, create an encryption enabled storageclass
3. Check the ocs_advanced_feature_usage metric from the UI by navigating to Observe -> Metrics
4. Check the Value parameter


Actual results:
---------------
The Value is 0


Expected results:
-----------------
Since, PV encryption is an advanced feature, the value should be 1

--- Additional comment from RHEL Program Management on 2022-12-05 14:06:36 IST ---

This bug having no release flag set previously, is now set with release flag 'odf‑4.12.0' to '?', and so is being proposed to be fixed at the ODF 4.12.0 release. Note that the 3 Acks (pm_ack, devel_ack, qa_ack), if any previously set while release flag was missing, have now been reset since the Acks are to be set against a release flag.

--- Additional comment from RHEL Program Management on 2022-12-05 14:06:36 IST ---

The keyword FutureFeature has been added.
If this BZ is not a Feature or Enhancement request, please remove from the Summary field any strings containing "RFE, rfe, FutureFeature, FEAT, Feat, feat".

--- Additional comment from Rachael on 2022-12-05 14:11:31 IST ---

Logs and screenshot: http://rhsqe-repo.lab.eng.blr.redhat.com/OCS/ocs-qe-bugs/2150752/

--- Additional comment from Sunil Kumar Acharya on 2022-12-05 20:28:12 IST ---

Moving the BZ out of ODF-4.12.0 as it is not proposed as blocker. If you think this BZ is a blocker for ODF-4.12.0, feel free to propose it back with sufficient justification.

--- Additional comment from Red Hat Bugzilla on 2023-01-01 01:34:15 IST ---

remove performed by PnT Account Manager <pnt-expunge>

--- Additional comment from Red Hat Bugzilla on 2023-01-01 14:14:29 IST ---

Account disabled by LDAP Audit

--- Additional comment from Red Hat Bugzilla on 2023-02-01 05:09:26 IST ---

remove performed by PnT Account Manager <pnt-expunge>

--- Additional comment from Red Hat Bugzilla on 2023-02-01 05:11:16 IST ---

remove performed by PnT Account Manager <pnt-expunge>

--- Additional comment from Sunil Kumar Acharya on 2023-03-06 18:11:33 IST ---

Moving the RFE BZ to ODF-4.14 as the Feature Freeze is completed for ODF-4.13.

--- Additional comment from arun kumar mohan on 2023-04-21 18:58:16 IST ---

We already had this PR: https://github.com/red-hat-storage/ocs-operator/pull/1826 , which was supposed to fix the issue.
As StorageClass is a cluster wide resource (and not a namespace constrained resource), may have to take a different approach.
Taking a look

--- Additional comment from arun kumar mohan on 2023-04-27 22:34:37 IST ---

Umanga has created a PR for this: https://github.com/red-hat-storage/ocs-operator/pull/2032
This is now backported to 4.13 branch as well: https://github.com/red-hat-storage/ocs-operator/pull/2033

--- Additional comment from umanga on 2023-05-04 11:08:24 IST ---

This is not a FeatureFeature. It's a bug that we have since 4.12.0.
Since the issue was fixed in 4.13, adding devel_ack+.

--- Additional comment from RHEL Program Management on 2023-05-04 12:23:35 IST ---

This BZ is being approved for ODF 4.13.0 release, upon receipt of the 3 ACKs (PM,Devel,QA) for the release flag 'odf‑4.13.0

--- Additional comment from RHEL Program Management on 2023-05-04 12:23:35 IST ---

Since this bug has been approved for ODF 4.13.0 release, through release flag 'odf-4.13.0+', the Target Release is being set to 'ODF 4.13.0

--- Additional comment from errata-xmlrpc on 2023-05-10 17:41:01 IST ---

This bug has been added to advisory RHBA-2023:108078 by Boris Ranto (branto)

--- Additional comment from Sunil Kumar Acharya on 2023-05-29 15:24:51 IST ---

Please update the RDT(requires_doc_text) flag/text appropriately.

--- Additional comment from Shay Rozen on 2023-05-30 14:05:49 IST ---

Added an encrypted storageclass checked the metric and it still 0. Moving to assigned.

--- Additional comment from Mudit Agarwal on 2023-05-30 16:28:24 IST ---

Not a blocker for 4.13

--- Additional comment from RHEL Program Management on 2023-05-30 16:28:32 IST ---

The 'Target Release' is not to be set manually at the Red Hat OpenShift Data Foundation product.

The 'Target Release' will be auto set appropriately, after the 3 Acks (pm,devel,qa) are set to "+" for a specific release flag and that release flag gets auto set to "+".

--- Additional comment from RHEL Program Management on 2023-06-16 12:57:58 IST ---

This BZ is being approved for ODF 4.14.0 release, upon receipt of the 3 ACKs (PM,Devel,QA) for the release flag 'odf‑4.14.0

--- Additional comment from RHEL Program Management on 2023-06-17 12:58:05 IST ---

Since this bug has been approved for ODF 4.14.0 release, through release flag 'odf-4.14.0+', the Target Release is being set to 'ODF 4.14.0

--- Additional comment from errata-xmlrpc on 2023-06-20 15:47:40 IST ---

This bug has been dropped from advisory RHBA-2023:108078 by Boris Ranto (branto)

--- Additional comment from Red Hat Bugzilla on 2023-08-03 14:01:14 IST ---

Account disabled by LDAP Audit