Bug 2233219

Summary:	Review Request: rust-lcms2-sys - Bindings for liblcms2
Product:	[Fedora] Fedora	Reporter:	Kalev Lember <klember>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-08-21 18:36:45 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Kalev Lember 2023-08-21 18:21:21 UTC

Spec URL: https://kalev.fedorapeople.org/rust-lcms2-sys.spec
SRPM URL: https://kalev.fedorapeople.org/rust-lcms2-sys-4.0.1-1.fc40.src.rpm
Description:
Bindings for liblcms2 (Little CMS) with support for Linux, macOS, and
Windows. See lcms2 crate for a safe Rust wrapper.

Fedora Account System Username: kalev

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=105089908

Comment 1 Kalev Lember 2023-08-21 18:23:52 UTC

There's some interesting bundling going on here and it would be good if someone who knows rust could review how I've dealt with it. I went with stripping out the bundled liblcms2 and removing the "static" and "static-fallback" features that seemed to expose this. Not entirely sure if that's the way to do it.

The rust2rpm.conf file that I used for generating the packaging is:

[DEFAULT]
buildrequires =
  pkgconfig(lcms2)
lib.requires =
  pkgconfig(lcms2)

Comment 2 Kalev Lember 2023-08-21 18:36:45 UTC

It turns out there is already another rust-lcms2-sys review: https://bugzilla.redhat.com/show_bug.cgi?id=2231910

Closing in favour of this.

*** This bug has been marked as a duplicate of bug 2231910 ***