Bug 2234609

Summary: Need correction in summary of "Title: Automatic registration into Red Hat Insights" in /var/log/leapp/leapp-report.txt log file
Product: Red Hat Enterprise Linux 8 Reporter: Suresh <sujagtap>
Component: leapp-repositoryAssignee: Leapp Notifications Bot <leapp-notifications-bot>
Status: CLOSED DUPLICATE QA Contact: upgrades-and-conversions
Severity: medium Docs Contact: Miriam Portman <mportman>
Priority: unspecified    
Version: 8.8CC: pstodulk, upgrades-and-conversions
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-08-25 08:50:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Suresh 2023-08-24 21:09:35 UTC
Description of problem:
=======================

For RHEl8 to RHEl9 upgrade using leapp , "leapp preugrade" generates /var/log/leapp/leapp-report.txt the below "Risk Factor: info" regarding "Automatic registration into Red Hat Insights"  need correction in summary.


Version-Release number of selected component (if applicable):
=============================================================
~~~
#rpm -qa |grep leapp
leapp-0.15.1-1.el8.noarch
leapp-upgrade-el8toel9-deps-0.18.0-1.el8_8.2.noarch
python3-leapp-0.15.1-1.el8.noarch
leapp-upgrade-el8toel9-0.18.0-1.el8_8.2.noarch
leapp-deps-0.15.1-1.el8.noarch
~~

How reproducible:
=================
Always

Steps to Reproduce:
===================

1. On registered and subscribed RHEl7.9 system to customer portal enable "rhel-7-server-extras-rpms" repository and install  package for leapp

 #yum install leapp-upgrade

2.Execute "leapp preupgrade"

3. Check /var/log/leapp/leapp-report.txt for "Title: Automatic registration into Red Hat Insights" You will see below message . 
~~~
Risk Factor: info
Title: Automatic registration into Red Hat Insights
Summary: After the upgrade, this system will be automatically registered into Red Hat Insights. To skip the automatic registration, use the '--no-insights-autoregister' command line option or set the NO_INSIGHTS_AUTOREGISTER environment variable.
~~~

'--no-insights-autoregister' is not correct option it should be "--no-insights-register" also 'NO_INSIGHTS_AUTOREGISTER' environment variable is not valid it should be "LEAPP_NO_INSIGHTS_REGISTER"

Reference:https://leapp.readthedocs.io/en/latest/el7toel8/envars.html#leapp-no-insights-register

Actual results:
===============
The leapp-report.txt shows incorrect command line option  and environment variable in summary to skip the automatic registration to insights during leapp.
~~~
Risk Factor: info
Title: Automatic registration into Red Hat Insights
Summary: After the upgrade, this system will be automatically registered into Red Hat Insights. To skip the automatic registration, use the '--no-insights-autoregister' command line option or set the NO_INSIGHTS_AUTOREGISTER environment variable.
~~~

Expected results:
=================

The message in leapp-report.txt  should be look like below
~~~
Risk Factor: info
Title: Automatic registration into Red Hat Insights
Summary: After the upgrade, this system will be automatically registered into Red Hat Insights. To skip the automatic registration, use the '--no-insights-register' command line option or set the LEAPP_NO_INSIGHTS_REGISTER environment variable.
~~~

Additional info:
=================

#leapp upgrade --help
~~~
  --no-insights-register
                        Do not register into Red Hat Insights
~~~

Reference:

https://leapp.readthedocs.io/en/latest/el7toel8/envars.html#leapp-no-insights-register

Comment 1 Petr Stodulka 2023-08-25 08:50:15 UTC
Hi Suresh \o thank you for the report. It's duplicate of bug 2222861 which is going to be fixed in the next release.

*** This bug has been marked as a duplicate of bug 2222861 ***