Bug 2234618

Summary: Flatpak cleanup-commands do not work
Product: [Fedora] Fedora Reporter: Owen Taylor <otaylor>
Component: flatpak-module-toolsAssignee: Owen Taylor <otaylor>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 39CC: awilliam, klember, otaylor
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: AcceptedFreezeException
Fixed In Version: flatpak-module-tools-1.0~a7-1.fc39 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-08-29 17:44:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2143445    

Description Owen Taylor 2023-08-24 22:25:11 UTC 
Due to a typo, with the new https://fedoraproject.org/wiki/Changes/FlatpaksWithoutModules  build system, the cleanup-commands key in container.yaml isn't read, and the "cleanup" steps in container creation (renaming files, etc) aren't executed.

 https://pagure.io/flatpak-module-tools/c/7c173d8fb26ffb60be946e3cc69dcee174c90021?branch=main

This will prevent many Flatpaks from building or working properly - if we don't have this in the buildroots that are created to build Flatpaks, this is going to prevent us from moving foward converting and building Flatpaks for F39.

This is fixed in flatpak-module-tools-1.0~a7-1.fc39.

Updating this package should have minimal risk to the beta, since flatpak-module-tools is not included in any release deliverable.
Comment 1 Adam Williamson 2023-08-27 16:27:03 UTC 
+3 in https://pagure.io/fedora-qa/blocker-review/issue/1198 , marking accepted.
Comment 2 Fedora Update System 2023-08-28 17:22:15 UTC 
FEDORA-2023-522cbc565c has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-522cbc565c
Comment 3 Fedora Update System 2023-08-29 17:44:58 UTC 
FEDORA-2023-522cbc565c has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.