Bug 2235325

Summary:	Deploying ovn-bgp-agent overrides frr per-role parameters
Product:	Red Hat OpenStack	Reporter:	Eduardo Olivares <eolivare>
Component:	openstack-tripleo-heat-templates	Assignee:	Luca Miccini <lmiccini>
Status:	CLOSED ERRATA	QA Contact:	Eduardo Olivares <eolivare>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	17.1 (Wallaby)	CC:	lmiccini, lsvaty, mariel, mburns
Target Milestone:	z1	Keywords:	Triaged
Target Release:	17.1
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	openstack-tripleo-heat-templates-14.3.1-1.20230519151023.el9ost	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-09-20 00:29:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2210151

Description Eduardo Olivares 2023-08-28 13:13:05 UTC

Description of problem:
During the verification of BZ2210151, the following parameters were configured at per-role level:
  ControllerRack1Parameters:
    FrrBgpAsn: 65101
    FrrOvnBgpAgentAsn: 65101
  ControllerRack2Parameters:
    FrrBgpAsn: 65102
    FrrOvnBgpAgentAsn: 65102
  ControllerRack3Parameters:
    FrrBgpAsn: 65103
    FrrOvnBgpAgentAsn: 65103
  ComputeRack1Parameters:
    FrrBgpAsn: 65101
    FrrOvnBgpAgentAsn: 65101
  ComputeRack2Parameters:
    FrrBgpAsn: 65102
    FrrOvnBgpAgentAsn: 65102
  ComputeRack3Parameters:
    FrrBgpAsn: 65103
    FrrOvnBgpAgentAsn: 65103


After the overcloud deploy was successful, we found some of the values were wrong on the overcloud nodes configuration (the following node is a compute from rack1, so its values should be 65101 in both cases):
[root@cmp-1-0 ~]# grep bgp_AS /var/lib/config-data/ansible-generated/ovn-bgp-agent/etc/ovn-bgp-agent/bgp-agent.conf
bgp_AS=65101
[root@cmp-1-0 ~]# grep "router bgp" /var/lib/config-data/ansible-generated/frr/etc/frr/frr.conf
router bgp 65103


After some investigation, it seems the problem is that the frr configuration, which is correctly generated at first, is overriden later during the step that generates the ovn-bgp-agent configuration. It seems the reason for this is that both frr and ovn-bgp-agent share the same role "tripleo_frr" when their configurations are generated.


Version-Release number of selected component (if applicable):
RHOS-17.1-RHEL-9-20230824.n.1
openstack-tripleo-heat-templates-14.3.1-1.20230519151022.el9ost.noarch
tripleo-ansible-3.3.1-1.20230518201537.el9ost.noarch

How reproducible:
100%

Steps to Reproduce:
1. Deploy Overcloud nodes with both Frr and OVNBgpAgent services
2. Configure per-role parameters with different values, like the configuration shown above 


Actual results:
values from the per-role parameters are wrong on the frr configuration

Expected results:
values from the per-role parameters are correct on the frr configuration

Comment 11 errata-xmlrpc 2023-09-20 00:29:56 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Release of components for Red Hat OpenStack Platform 17.1.1 (Wallaby)), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:5138