Bug 2236057

Summary: Failed to preset virtsecretd/virtsecretd*.socket service when installing libvirt pkgs
Product: Red Hat Enterprise Linux 9 Reporter: yafu <yafu>
Component: libvirtAssignee: Andrea Bolognani <abologna>
libvirt sub component: General QA Contact: Lili Zhu <lizhu>
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: unspecified CC: abologna, haizhao, jdenemar, jsuchane, jwboyer, lmen, virt-maint
Version: 9.3Keywords: Automation, Regression, Triaged
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-9.5.0-7.el9_3 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-11-07 08:31:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version: 9.7.0
Embargoed:

Description yafu 2023-08-30 09:10:45 UTC
Description of problem:
Failed to preset virtsecretd/virtsecretd*.socket service when installing libvirt pkgs. It is caused by spelling mistake: "virsecretd" should be "virtsecretd"

Version-Release number of selected component (if applicable):
libvirt-9.5.0-6.el9.x86_64

How reproducible:
100%

Steps to Reproduce:
1.Install libvirt pkgs:
#dnf -y install libvirt*
...
Running scriptlet: libvirt-daemon-driver-secret-9.5.0-6.el9.x86_64                                                                      145/145 
Failed to preset unit: Unit file ***virsecretd.socket*** does not exist.
Failed to preset unit: Unit file ***virsecretd-ro.socket*** does not exist.
Failed to preset unit: Unit file ***virsecretd-admin.socket*** does not exist.
Failed to preset unit: Unit file ***virsecretd.service*** does not exist.
...

2.Check the service status of virtsecretd.socket:
# systemctl status virtsecretd.socket
○ virtsecretd.socket - Libvirt secret local socket
     Loaded: loaded (/usr/lib/systemd/system/virtsecretd.socket; disabled; preset: enabled)
     Active: inactive (dead)
   Triggers: ● virtsecretd.service
     Listen: /run/libvirt/virtsecretd-sock (Stream)


3.

Actual results:
Failed to preset virtsecretd/virtsecretd*.socket service when installing libvirt pkgs because of spelling mistake for 'virtsecretd'.

Expected results:
Preset virtsecretd/virtsecretd*.socket service when installing libvirt pkgs and virtsecretd.socket service should be enabled after installing.

Additional info:
It's a regression issue. Can not reproduced with libvirt-9.5.0-6.el9.x86_64

Comment 1 Andrea Bolognani 2023-08-30 15:40:30 UTC
(In reply to yafu from comment #0)
> Failed to preset virtsecretd/virtsecretd*.socket service when installing
> libvirt pkgs. It is caused by spelling mistake: "virsecretd" should be
> "virtsecretd"

Good catch!

I'll prepare and push a fix upstream right away.

Comment 2 Andrea Bolognani 2023-08-30 16:04:42 UTC
Fix pushed upstream.

  commit e7d26c5dcd3b988fa02ac1e45baf2f9934623381
  Author: Andrea Bolognani <abologna>
  Date:   Wed Aug 30 17:41:14 2023 +0200

    rpm: Fix typo in daemon name
    
    The name of the virtsecretd daemon was misspelled, resulting
    in multiple errors during installation:
    
      Running scriptlet: libvirt-daemon-driver-secret-9.5.0-6.el9.x86_64
      Failed to preset unit: Unit file virsecretd.socket does not exist.
      Failed to preset unit: Unit file virsecretd-ro.socket does not exist.
      Failed to preset unit: Unit file virsecretd-admin.socket does not exist.
      Failed to preset unit: Unit file virsecretd.service does not exist.
    
    Spell the name correctly.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=2236057
    
    Signed-off-by: Andrea Bolognani <abologna>

  v9.7.0-rc2-1-ge7d26c5dcd

Comment 5 Andrea Bolognani 2023-08-31 13:23:53 UTC
Backport posted.

  https://gitlab.com/redhat/centos-stream/src/libvirt/-/merge_requests/9

Comment 8 Lili Zhu 2023-09-08 04:47:01 UTC
Tested this bug by applying commit in Comment #2 to libvirt-9.5.0-6
1. install libvirt-daemon-kvm
# yum install ./libvirt*
(No errors as those in bug descrption showed up)

2. check daemon and socket status
# systemctl status virtsecretd.socket
○ virtsecretd.socket - Libvirt secret local socket
     Loaded: loaded (/usr/lib/systemd/system/virtsecretd.socket; enabled; preset: enabled)
     Active: inactive (dead)
   Triggers: ● virtsecretd.service
     Listen: /run/libvirt/virtsecretd-sock (Stream)

# systemctl status virtsecretd
○ virtsecretd.service - Virtualization secret daemon
     Loaded: loaded (/usr/lib/systemd/system/virtsecretd.service; disabled; preset: disabled)
     Active: inactive (dead)
TriggeredBy: ○ virtsecretd-ro.socket
             ○ virtsecretd.socket
             ○ virtsecretd-admin.socket
       Docs: man:virtsecretd(8)
             https://libvirt.org

Comment 9 Lili Zhu 2023-09-08 08:26:17 UTC
Tested with:
libvirt-9.5.0-7.el9_3.x86_64

Testing steps are the same with those in Comment #8.

Comment 12 Lili Zhu 2023-09-12 02:13:56 UTC
According to Comment #9, mark the bug as verified.

Comment 14 errata-xmlrpc 2023-11-07 08:31:41 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: libvirt security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:6409